src/ fixes (BOOL CAST nulls, fused_group LIKE, emit-filter ordering) + cleanups + coverage round 9-10

[ser-vasilich]

Summary

8 commits since #211 merged. Mixed src/ fixes, cleanups, and a large test push from round 9-10 agents.

Coverage delta (vs #211 baseline):

Metric	Before	After	Δ
Functions	97.83% (44 missed)	98.13% (39)	-5 missed
Lines	87.06%	88.44%	+1.38 pp
Regions	82.24%	83.27%	+1.03 pp
Branches	65.01%	65.86%	+0.85 pp

Files below 80% regions dropped from 7 to 4.

Src/ bug fixes (all with TDD regression tests)

fix(expr) null-sentinel handling in CAST → BOOL (87df4cdf)

Two related defects surfaced by the expr.c coverage agent:

1. F64 → BOOL: dst[i] = (src[i] != 0.0) ? 1 : 0 accidentally treated NaN as truthy. IEEE 754 says NaN != 0.0 is true — and NULL_F64 = __builtin_nan(""). Every null F64 silently became true. Fixed both fused (expr_exec_unary) and non-fused (exec_elementwise_unary) paths with && a[j] == a[j] (NaN check).
2. I64 → BOOL: the branch if (in_type == RAY_I64 && out_type == RAY_BOOL) at expr.c:1360 was meant as the OP_ISNULL specialisation but had no opcode gate. OP_CAST I64→BOOL silently returned all zeros regardless of input. Fixed by gating on opc == OP_ISNULL for the existing zero-fill and adding an opc == OP_CAST arm with truthy semantics + NULL_I64 (INT64_MIN) skip.

Convention chosen: BOOL is non-nullable, so casting nullable to BOOL must pick a side. Treat "missing" as false (SQL-style: null doesn't satisfy a predicate). Symmetric for F64 and I64 inputs.

fix(fused_group) evaluate FP_LIKE in fp_eval_cmp_one (55c94409)

fp_eval_cmp_one returned 0 for ALL column types when p->op == FP_LIKE. Reachable via mk_eq_i64_count_fn at fused_group.c:2576 — every non-FP_EQ child of a composite AND is evaluated per-row. A query like:

(select {n: (count k) by: [k1 k2] from: T
         where: (and (== fc 0) (like s "*foo*"))})

routed through this path: eq_idx picked the (== fc 0), then the LIKE child evaluated to constant 0, collapsing every match → empty result.

Fix mirrors the bulk fp_eval_cmp implementation: RAY_SYM uses like_lut cache + like_sym_strings, RAY_STR uses ray_str_vec_get directly, both feeding ray_glob_match[_compiled].

fix(query) hoist emit-filter match so fp_try_i32_mg_top_count fires (8e3960ed)

fp_try_i32_mg_top_count (and the i16x2 specialisation) require the no-WHERE count-key DAG branch to be selected at compile time, gated by a ray_group_emit_filter_get() read at query.c:~7541. But the filter was being installed AFTER DAG construction (just before ray_execute) so the compile-time read always saw enabled=false — the optimisation was permanently unreachable from RFL. ~160 regions of specialised code sat as dead.

Fix: hoist match_group_desc_count_take to before the by_expr branch and stash the result. At the compile-time read, prefer the pre-computed filter. The thread-local set is still deferred to just before ray_execute so state-leakage on error paths is unchanged.

Affects ClickBench-style select count by k take N desc queries.

Plus 4 bugs from the parent round still resolved here via test regression updates

(Earlier round: heap GC SEGV, narrow CAST, raise compiled lambda, exec_if SYM atom, ray_vec_insert_at — all already in PR #211 / earlier.)

Cleanups (no behaviour change beyond removing dead code)

feat(temporal) bind .year, .month, .hour dotted trunc forms (c83dc16a)

Three previously-dead DATE_TRUNC_INNER macro arms (instantiated 4× = ~120 LOC of object code) become live by adding the corresponding sym mappings to ray_temporal_trunc_from_sym. New RFL surface: ts.year (truncates to Jan 1), ts.month, ts.hour. "minute" intentionally NOT bound — it collides with the extract resolver which query.c tries first.

chore(expr) drop unreachable narrow OP_DIV cases in binary_range (4cdc10d3)

ray_div and ray_binop(OP_DIV, ...) both hard-code out_type = RAY_F64; narrow output for OP_DIV is unreachable. Removed 3 dead case bodies (I32/I16/U8) with one-line comments at each. OP_IDIV cases stay — ray_binop(OP_IDIV) falls into the default: arm using promote() which CAN return narrow.

chore(types) remove unfinished sym_dict infrastructure (~60 LOC) (0f61b2f3)

Cross-repo git archeology (teide → rayforce2 → current) confirmed sym_dict was scaffolded in teide, propagation extended in rebases, but no constructor was ever written. Every read site read NULL. Each propagation site also called ray_retain(X->sym_dict) without a matching release — latent refcount leak hidden by the always-NULL state. Deleted: union member + 6 propagation/read sites + comment references. ray_sym_dict_width() retained (it's a CSV-ingest sizing helper, unrelated to the field).

Test commits

• test(sym/internal) (b89c5bee): sym lazy-load via sparse 64MB files (fseek + 1-byte trick), env-gated trace via setenv in C tests. Plus 3 sections in internal_coverage.rfl driving parallel narrow group-by paths. sym.c 80.19% → 87.47% / internal.h 78.58% → 83.30%.
• test: round 9-10 (fa88b185): 15 test files / 7 new group/, journal arms via crafted log files, splay via RAY_CSV_TRACE setenv + chmod, 7 C tests in test_traverse.c.

Test plan

• make clean && make test (debug, ASan+UBSan): 2719 of 2721 PASS, 0 failed (2 pre-existing skips)
• Each src/ bug fix has a TDD regression test that fails before the fix and passes after
• No _probes/, no hidden xfail
• No src/ test-only de-staticing, no internal headers added for tests
• make coverage measured: 82.24% → 83.27% regions

Files still below 80% regions (next round candidates)

• src/ops/expr.c 71.78% — agent C-level work pushed from 63.25%, documented hard RFL ceiling
• src/ops/journal.c 77.10% — defensive OOM/serde guards, needs fault injection
• src/ops/traverse.c 77.85% — ~688 of 721 missed are real OOM boundary checks
• src/ops/group.c 79.97% — just under 80%, ~17 regions away

🤖 Generated with Claude Code