Fix crash on performWorldGenSpawning#349
Open
blnchdev wants to merge 1 commit intoRayTrace082:1.18.2from
Open
Conversation
performWorldGenSpawning -> onFinalizeSpawn -> EntitySpitter.updateAttributes -> ComplexMob.breed This deadlocks the server thread!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
performWorldGenSpawning() -> onFinalizeSpawn() -> EntitySpitter.updateAttributes() -> ComplexMob.breed()
WorldGen spawning causes some ComplexMob instances to breed (maybe due to wantsToBreed always returning true?), which is illegal when called from a worldGen thread
So we just return early on breed() if the caller isn't the server main thread, this fixes the crash but I'm unsure if any features are affected