Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add and modify some file to fit linux platform #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add and modify some file to fit linux platform #9

wants to merge 1 commit into from

Conversation

how0723
Copy link

@how0723 how0723 commented Jul 10, 2019

add and modify some file to fit linux platform

Raveler
Raveler reviewed Jul 11, 2019
View reviewed changes
Copy link
Owner

@Raveler Raveler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

A few questions.

  • Why did you put the nullptr definition in AudioFormatConverter.h? Might be more logical better in ffmpeg.h.
  • Why did you remove the call to the base constructor from FFmpegException.cpp?

@siniarskimar siniarskimar mentioned this pull request Jul 27, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raveler Raveler Raveler left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@how0723 @Raveler