Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux version #26

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

linux version #26

wants to merge 2 commits into from

Conversation

cdubet
Copy link

@cdubet cdubet commented Dec 22, 2020

making linux version working:

  • Create a basic cmake (the exe are not at the right place yet)
  • removing some windows only header
  • fixing typos (was OK on windows because file name are not case sensitive)
  • fixing exception (no ctor with string, pass it by reference instead of copy)
  • short intro how to use it on linux in readme

@ebachard
Copy link

Reading your cmake file I have some doubts with some path containing spaces. Is it really something for Linux ?

FYI : https://github.com/ebachard/ffmpeg-cpp

As you can see, the linux version exists since a long while. I just protected my work from "pillage" (sorry french word ... could it be looting ?). + I added some proofs of concepts who could be ported on Windows without too much changes (some are obvious).

@cdubet
Copy link
Author

cdubet commented Jan 12, 2021

Reading your cmake file I have some doubts with some path containing spaces. Is it really something for Linux ?
yes it is.
It works at least for linux mint 20

I made it quickly because I needed a ffmpeg wrapper for a small tool
I am not a cmake specialist so there are for sure things that could be done better (for ex if ffmpeg is installed with package or from the source)
which line is disturbing you ?

PS: pillage is looting as far as I know (french is my mother language so my english is not a reference)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants