Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a cspTier field to the escrow details returned by the Reader contract, exposing the CSP tier alongside other escrow metadata.
Changes:
- Extend
EscrowDetailsstruct andICspEscrowinterface inReader.solwith acspTierfield/getter, and populate it ingetAllEscrowsDetailsandgetEscrowDetailsByOwner. - Update
Reader.test.tsto map and assert the newcspTierfield, exercisingsetCspTieronpoaiManager. - Refresh
.openzeppelin/base-sepolia.jsonstorage layout (type AST id renumbering and a new Reader proxy entry).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| contracts/Reader.sol | Add cspTier to EscrowDetails, declare cspTier() on ICspEscrow, populate field in both escrow detail getters. |
| test/Reader.test.ts | Map cspTier in formatEscrowDetails and assert it (including setCspTier calls) in the escrow details tests. |
| .openzeppelin/base-sepolia.json | Update storage layout AST type IDs and add a new Reader proxy deployment entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cristibleotiu
approved these changes
May 18, 2026
Contributor
Gas usage comparisonBase commit: Summary
Largest method changesNo significant method gas differences detected. Deployment changes
All method measurements
All deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.