Develop - #45
Merged
Merged
Conversation
Fix MND reward display
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the MND/GND rewards calculation path to match an updated calculateRewards contract interface, fixing reward display by sending a contiguous epoch range plus packed availability bytes rather than per-epoch arrays.
Changes:
- Replace
epochs[]/availabilies[]compute params withfromEpoch,toEpoch, andpackedAvailabilities. - Add stricter validation that the oracle-provided epochs fully cover a contiguous
[firstEpochToClaim..currentEpoch-1]range before attempting reward calculation. - Update the MND contract ABI typings to reflect the new struct field layout and types.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| typedefs/blockchain.ts | Updates ComputeParam to the new range + packed-bytes availability shape. |
| lib/api/blockchain.ts | Packs epochs_vals into a hex-bytes payload and calls calculateRewards with fromEpoch/toEpoch, with added contiguity/range guards. |
| blockchain/MNDContract.ts | Updates calculateRewards (and related struct usage) ABI input types to uint256 fromEpoch, uint256 toEpoch, bytes packedAvailabilities. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix MND reward display