Fix MND reward display - #44
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes MND reward rendering in the Explorer by aligning the calculateRewards call with the deployed MND contract’s updated parameter shape (epoch range + packed availability bytes), preventing the contract read from reverting and the UI from falling back to ....
Changes:
- Update the Explorer’s MND ABI
calculateRewardstuple fields from{ epochs, availabilies }to{ fromEpoch, toEpoch, packedAvailabilities }. - Add validation that oracle epoch data is complete and contiguous, then pack
epochs_valsinto abyteshex payload. - Pass
fromEpoch/toEpochalong withpackedAvailabilitiesintocalculateRewards.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
typedefs/blockchain.ts |
Updates the ComputeParam shape to match the new MND contract compute params. |
lib/api/blockchain.ts |
Ensures epochs are contiguous/complete, packs availability into bytes, and updates the MND calculateRewards call args. |
blockchain/MNDContract.ts |
Updates the MND ABI tuple component definitions to the deployed contract’s signature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packedAvailabilitiesand passfromEpoch/toEpochtocalculateRewardsRoot Cause
MND rewards were rendered as
...because the Explorer still calledcalculateRewardswith the old{ epochs, availabilies }tuple. The deployed MND contract expects{ fromEpoch, toEpoch, packedAvailabilities }, so the read reverted and the UI treated the reward as unavailable.Validation
npm run lintnpm run build/license/MND/17renderedRewards (PoA)as55 $R1with9.94 carryoverinstead of...Note:
npm run buildstill logs existing stats-page upstream transfer JSON warnings (Must be au...) during static generation, but the build exits successfully.