fix: reject stale Deeploy lifecycle commands - #206
Draft
cristibleotiu wants to merge 1 commit into
Draft
Conversation
What changed: - accept structured Deeploy DELETE_CONFIG payloads while preserving legacy string deletes - skip Deeploy update/delete commands when their lifecycle marker is older than current state - add fixture-backed receiver tests for stale delete and tombstone behavior Why: - prevent delayed Deeploy deletes from stopping a newer updated app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DELETE_CONFIGpayloads while preserving legacy string deletesWhy
Cap_34 showed an older Deeploy delete can arrive after a newer update and stop the refreshed app. This adds the receiver-side half of the ordering contract.
Validation
/home/bleot/venvs/umbrella313/bin/python -m unittest naeural_core.business.test_framework.test_deeploy_lifecycle_ordering-> 7 tests passed/home/bleot/venvs/umbrella313/bin/python -m compileall naeural_core/config/config_manager_commands.py naeural_core/business/mixins_base/cmdapi.py naeural_core/business/test_framework/test_deeploy_lifecycle_ordering.pygit diff --checkedge_nodebranch with this local core mounted: create generation 1, update generation 2, stale delete ignored, current delete accepted, resultokNotes
edge_nodePR is deployed; the edge branch emits structured delete payloads.DELETE_CONFIGremains unconditional.