Skip to content

Unitroller has FuseAdmin hardcoded into its bytecode inside of FusePoolDirectory causes issues with unit testing #18

Description

@zerosnacks

Midas Protocol has replaced the implementation with a dynamically constructed type(foo).creationCode + constructorData allowing you to pass in a fuseAdmin into the constructor.

Would it be feasible to replace our implementation where we have hardcoded the fuseAdmin address? @sriyantra
If not I can try to come up with ways that we can work around this limitation but it would mean that any tests we write are effectively integration tests.

https://github.com/Midas-Protocol/contracts/blob/a9c9f1d7d1c3106c545056d4af9105393aef29fc/contracts/FusePoolDirectory.sol#L144-L237

https://github.com/Midas-Protocol/contracts/blob/a9c9f1d7d1c3106c545056d4af9105393aef29fc/contracts/compound/Comptroller.sol#L1333-L1365

Related PR is #17

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions