preserve dissolution stake settlement cursor

[UnArbosSix]

Motivation

Stake settlement during subnet dissolution is resumable across blocks. When the weight budget was exhausted after reading a hotkey but before queuing its payout, the settlement cursor advanced past that unpaid hotkey because iter_from resumes exclusively after the supplied key.

Changes

• Track the last fully completed TotalHotkeyAlpha storage key during stake settlement.
• Preserve the incoming cursor when the next hotkey cannot be fully processed within the remaining weight.
• Add regression tests for exhaustion before the first payout and after a previous hotkey has completed.

Behavioral impact

An unpaid hotkey is retried during the next dissolution settlement pass, while already completed hotkeys remain excluded. This prevents stake payouts from being skipped at weight-budget boundaries.

Migration and runtime version

No storage migration is required. The PR targets main, where the configured live-network spec-version checks do not require an automatic bump.

Testing

Added targeted unit tests in pallets/subtensor/src/tests/destroy_alpha_tests.rs covering both cursor boundary cases.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
subtensor	Ready	Preview, Comment	Jul 14, 2026 4:38pm

[github-actions]

🛡️ AI Review — Skeptic (security review)

VERDICT: SAFE

VERY HIGH raw scrutiny (12-day-old account, 13 lifetime contributions, no public repos), mitigated by repository write permission and no known Gittensor association; branch correctly targets main.

Static analysis confirms the cursor remains a TotalHotkeyAlpha storage key and advances only after a hotkey is fully queued for payout. The change does not touch protected review instructions, dependencies, build scripts, origin checks, or storage formats.

Findings

No findings.

Conclusion

The patch fixes the weight-boundary payout skip without introducing a security vulnerability or suspicious behavior.

---

🔍 AI Review — Auditor (domain review)

VERDICT: 👍

Gittensor association UNKNOWN; the account is new with sparse public history but has repository write access. No overlapping PR was identified.

Static inspection confirms the cursor advances only after a hotkey is fully queued for payout. If weight is exhausted mid-hotkey, the previous completed cursor is retained, retrying the unpaid hotkey without repaying completed ones.

The focused regression tests cover both cursor boundary cases, and the PR description matches the implementation. No spec-version or other auto-fix is required.

Findings

No findings.

Conclusion

The change correctly fixes the exclusive iter_from resume boundary and provides appropriate regression coverage. No substantive correctness issues were found.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[github-actions]

AI review — see the sticky summary comment for the verdict and the inline comments below for specific findings.

[github-actions]

🔄 AI review updated — Skeptic: VULNERABLE

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[unarbos]

Cursor semantics fix is correct: only advance past fully paid hotkeys, and preserve the incoming cursor when no hotkey completes in a pass. Tests cover both regressions. Clone-upgrade failure was stale codegen drift fixed on main; branch updated.

[github-actions]

🔄 AI review updated — Skeptic: SAFE Auditor: 👍

[IntiTechnologies]

Superseded by #2898 (v431 release): these changes were reviewed and integrated there.