Implement custom save location, more specific file naming system, and helpful feedback for errors#34
Open
Larkteryny wants to merge 4 commits intoRameshAditya:masterfrom
Open
Implement custom save location, more specific file naming system, and helpful feedback for errors#34Larkteryny wants to merge 4 commits intoRameshAditya:masterfrom
Larkteryny wants to merge 4 commits intoRameshAditya:masterfrom
Conversation
Optional argument to save output to custom directory and/or custom filename
Images retrieved from URLs named according to filename in URL
Output txt filename default format is "{original image filename}-asciified"
When writing output to file, handles FileNotFoundError and PermissionError Displays readable error messages for each
Optional custom save location
Provides more readable feedback to user when these 2 cases occur
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional argument to save output to custom directory and/or custom filename
Images retrieved from URLs named according to filename in URL
Filename of saved output has new default format of "{original image filename}-asciified.txt"
More readable/useful error messages when: