feat: tried solved test error in the pipeline.

RaiolaNetworks · Sep 18, 2024 · f91872c · f91872c
1 parent dca2b94
commit f91872c
Show file tree

Hide file tree

Showing 6 changed files with 16 additions and 18 deletions.
diff --git a/.github/workflows/run-tests.yml b/.github/workflows/run-tests.yml
@@ -1,4 +1,4 @@
-name: run-tests
+name: Pest
 
 on:
   push:
@@ -16,7 +16,7 @@ jobs:
     strategy:
       fail-fast: true
       matrix:
-        os: [ubuntu-latest, windows-latest]
+        os: [ubuntu-latest]
         php: [8.3, 8.2]
         laravel: [11.*, 10.*]
         stability: [prefer-lowest, prefer-stable]

diff --git a/composer.json b/composer.json
@@ -49,6 +49,7 @@
     "autoload-dev": {
         "psr-4": {
             "Raiolanetworks\\OAuth\\Tests\\": "tests/",
+            "Raiolanetworks\\OAuth\\Tests\\Database\\Factories\\": "tests/database/factories/",
             "Workbench\\App\\": "workbench/app/",
             "Workbench\\Database\\Factories\\": "workbench/database/factories/",
             "Workbench\\Database\\Seeders\\": "workbench/database/seeders/"

diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -15,11 +15,8 @@
     backupStaticProperties="false"
 >
     <testsuites>
-        <testsuite name="Unit">
-            <directory suffix="Test.php">./tests/Unit</directory>
-        </testsuite>
-        <testsuite name="Feature">
-            <directory suffix="Test.php">./tests/Feature</directory>
+        <testsuite name="Raiola Networks - Development Team">
+            <directory>tests</directory>
         </testsuite>
     </testsuites>
     <source>

diff --git a/src/Commands/OAuthCommand.php b/src/Commands/OAuthCommand.php
@@ -59,9 +59,9 @@ protected function setConfigVariables(): void
         );
 
         $loginRoute = text(
-            label: 'Login route:',
-            placeholder: 'E.g. /login',
-            default: '/login',
+            label: 'Login route name:',
+            placeholder: 'E.g. login',
+            default: 'login',
         );
 
         config()->set('oauth.user_model_name', $modelName);

diff --git a/tests/Feature/CommandTest.php b/tests/Feature/CommandTest.php
@@ -12,7 +12,7 @@
     $this->artisan('oauth:install')
         ->expectsQuestion('Model name Authenticatable:', TestUser::class)
         ->expectsQuestion('Main guard name:', 'web')
-        ->expectsQuestion('Login route:', '/login')
+        ->expectsQuestion('Login route name:', 'login')
         ->expectsQuestion('Oauth base url:', 'https://asgard.your.company')
         ->expectsQuestion('Oauth client ID:', 'CLIENTID')
         ->expectsQuestion('Oauth client secret key:', 'SECRETKEY')

diff --git a/tests/Feature/ControllerTest.php b/tests/Feature/ControllerTest.php
@@ -71,37 +71,37 @@
     // Temporal route
     Route::get('/login', function () {
         return 'Login Page';
-    })->name(config()->string('oauth.login_route_name'));
+    })->name(config('oauth.login_route_name'));
 
     Session::put('oauth2-state', 'correct_state');
 
     $response = $this->get(route('oauth.callback'), [
         'state' => 'correct_state',
     ]);
 
-    $response->assertRedirect(route(config()->string('oauth.login_route_name')))
+    $response->assertRedirect(route(config('oauth.login_route_name')))
         ->assertSessionHas('message', 'Authentication failed. Please try again.');
 });
 
 it('handles invalid state in callback', function () {
     // Temporal route
     Route::get('/login', function () {
         return 'Login Page';
-    })->name(config()->string('oauth.login_route_name'));
+    })->name(config('oauth.login_route_name'));
 
     $response = $this->get(route('oauth.callback', [
         'code' => 'valid_code',
     ]));
 
-    $response->assertRedirect(route(config()->string('oauth.login_route_name')))
+    $response->assertRedirect(route(config('oauth.login_route_name')))
         ->assertSessionHas('message', 'Authentication failed. Please try again.');
 });
 
 it('logs in the user after a successful OAuth callback', function () {
     // Temporal route
     Route::get('/login', function () {
         return 'Login Page';
-    })->name(config()->string('oauth.login_route_name'));
+    })->name(config('oauth.login_route_name'));
 
     $mockOAuthService = Mockery::mock(OAuthService::class);
 
@@ -196,7 +196,7 @@
     // Temporal route
     Route::get('/login', function () {
         return 'Login Page';
-    })->name(config()->string('oauth.login_route_name'));
+    })->name(config('oauth.login_route_name'));
 
     $mockOAuthService = Mockery::mock(OAuthService::class);
 
@@ -230,6 +230,6 @@
     expect($mockUser->oauth_token_expires_at)->toBeNull();
 
     expect($response->getStatusCode())->toBe(302);
-    expect($response->headers->get('Location'))->toBe(route(config()->string('oauth.login_route_name')));
+    expect($response->headers->get('Location'))->toBe(route(config('oauth.login_route_name')));
     expect(session('message'))->toBe('Your session has expired. Please log in again.');
 });