test: add compliant minting invariant tests

[jd5073356-max]

Description

Adds a deterministic scenario matrix (src/test.rs) covering mint_asset's compliance and authorization invariants: compliant success, non-whitelisted recipient, unauthorised issuer, invalid (non-Active) asset state, revoked compliance, and repeated rejected attempts — each asserting both the specific error variant and that balance/total supply are left byte-for-byte unchanged.

main did not compile and, once fixed, had 16 failing pre-existing tests plus a real production bug directly relevant to this issue's "invalid asset minting is rejected" criterion — see below. Each is its own commit, ahead of the actual test-suite addition.

Related Issues

Closes #8

Completion Table

Acceptance Criterion	Status	Implementation Evidence	Test Evidence
AC 1: Compliant minting success path is tested	Complete	mint_asset (src/asset.rs), unchanged	test_compliant_mint_succeeds_and_updates_balance_and_supply
AC 2: Non-whitelisted recipient minting is rejected	Complete	compliance::require_can_receive (src/asset.rs)	test_mint_rejects_non_whitelisted_recipient_and_leaves_state_unchanged
AC 3: Unauthorised issuer minting is rejected	Complete	require_role(&admin, Role::AssetManager) (src/asset.rs)	test_mint_rejects_unauthorised_issuer_and_leaves_state_unchanged
AC 4: Invalid asset minting is rejected	Complete	require_asset_movable (src/asset.rs) — plus a real bug fix, see below	test_mint_rejects_invalid_asset_state_and_leaves_state_unchanged (Draft and Retired cases)
AC 5: Revoked compliance state is tested	Complete	compliance::require_can_receive (src/asset.rs)	test_mint_rejects_revoked_compliance_and_leaves_state_unchanged
AC 6: State remains consistent after failed minting	Complete	No mutation occurs before all mint_asset checks pass (src/asset.rs)	Every rejection test above asserts get_balance_of/get_total_supply unchanged; test_repeated_rejected_mint_attempts_never_mutate_state additionally covers 5 repeated failures in a row

Detailed Traceability Mapping

Acceptance Criteria	Implementation	Storage & State Changes	Events Emitted	Test Coverage	Security/Safety Controls
AC 4 (invalid asset)	Fixed asset::get_asset_status_internal default from Active to Draft (src/asset.rs)	No new storage keys; corrects the default read of the existing DataKey::AssetStatus key	None added	test_mint_rejects_invalid_asset_state_and_leaves_state_unchanged	Closes a real gap: before this fix, a freshly-initialized contract could be minted against immediately, without the admin ever calling set_asset_status(Active) — see "Pre-existing issues" below
All ACs	6 new #[test] functions in src/test.rs, no production logic changed beyond the AC 4 fix	N/A (test-only, except the one-line default fix)	N/A	See Completion Table	N/A

Type of Change

• Bug fix (non-breaking change which fixes an issue) — see "Pre-existing issues" below
• New feature (non-breaking change which adds functionality) — the invariant tests requested by this issue
• Breaking change
• Documentation update
• Chore

Pre-existing issues found and fixed (blocking, discovered while establishing a clean baseline)

1. main did not compile. Two orphaned closing braces in src/test.rs (cargo check --workspace --tests failed outright) — one right after a section-header comment with no matching opener, one duplicated at the end of the file. Fixed in an isolated commit.

2. A real production bug, directly relevant to this issue's AC 4. asset::get_asset_status_internal (what require_asset_movable — the check mint_asset/transfer actually call — reads) defaulted an unset asset status to Active. lifecycle::get_asset_status (what set_asset_status itself reads) defaults the same storage key to Draft. Both the AssetStatus enum docs and lifecycle::get_asset_status's own doc comment are explicit that Draft is the intended initial state requiring an explicit activation step — but the mismatched default meant mint_asset silently treated an un-activated contract as Active. Verified with a throwaway probe before fixing: minting succeeded on a freshly-initialized contract that had never called set_asset_status. Fixed the default to Draft, matching the documented design and the already-correct writer-side check.

3. 16 pre-existing failing tests in src/test.rs, surfaced once (1) and (2) above were fixed — all either depended on the buggy Active default (a shared test helper never explicitly activated the asset, only "working" because of the bug) or asserted a stale error taxonomy / hardcoded count that had drifted from the current code:

• setup_transferable() helper never called set_asset_status(Active), unlike the sibling setup_active() helper — added the missing call.
• One test's now-redundant re-activation call (hit the "no-op transition rejected" path once the helper above was fixed) — removed.
• test_restriction_checks_never_panic_on_uninitialized_contract expected the wrong first-blocking-reason on an uninitialized contract, contradicting evaluate_transfer's own documented check order — corrected.
• 6 assertions expected the older AssetLifecyclePaused/AssetRetired/AssetBlocked errors (6001-6003) instead of the current *Restriction variants (7000-7002) that require_asset_movable actually returns, per its own doc comment.
• 1 assertion expected InvalidAssetStatusTransition (6005, defined but never actually raised anywhere) instead of InvalidLifecycleTransition (6004, what set_asset_status actually returns).
• 1 test hardcoded HoldingCapExceeded/SupplyCapExceeded at 7003/7004 instead of their real, stable (append-only per errors.rs) codes 5003/5002.
• 4 assertions across 2 tests hardcoded get_capability_keys().len() at 28 or 31 instead of the current, correct count of 33.

Each of the three items above is a separate, minimal commit ahead of the actual test-suite addition, in dependency order.

Not fixed (out of scope, unrelated, flagging for visibility): cargo test --workspace still has 2 pre-existing failures in the separate tests/sdk_fixtures.rs integration target — fixture drift against the committed JSON snapshots in fixtures/sdk/. Confirmed independent of everything in this PR (that target doesn't depend on src/test.rs, and the library itself always compiled even before the brace fix). The repo documents a UPDATE_FIXTURES=1 cargo test --test sdk_fixtures regeneration flow for intentional changes, but understanding why it drifted needs its own investigation rather than a blind regenerate.

PR Evidence Checklist

1. Issue Reference

• Closes Add compliant minting invariant tests #8.

2. Implementation Summary

• See Description and Detailed Traceability Mapping above. Files touched: src/test.rs (brace fixes, 8 corrected assertions, 6 new tests), src/asset.rs (1-line default-value fix).

3. Tests Added or Justification

• 6 new tests, listed in the Completion Table, all in src/test.rs. Every rejection case covers both the failure path and post-failure state consistency.

4. Commands Run

• cargo test --lib: 180 passed; 0 failed (was uncompilable, then 16 failing, before the two prerequisite fix commits).
• cargo fmt --all -- --check: clean on every file this PR touches (src/asset.rs, src/test.rs) — pre-existing formatting drift in config.rs/config_test.rs/lib.rs and two untouched lines of test.rs is unrelated and left alone.
• cargo clippy --all-targets: no new warnings introduced (verified by diffing warning output before/after); all remaining warnings are pre-existing and in code this PR doesn't touch.
• cargo build --release --target wasm32v1-none: succeeds.

5. CI Status

• This repo's only GitHub Actions workflows are auto-merge/auto-assign triggers — there is no build/test/lint CI gate to report green. make verify (documented as "the recommended pre-push check") is the local equivalent, covered above.

6. Acceptance Criteria Coverage

• All 6 acceptance criteria addressed — see Completion Table.

Policy & Standards

• Read the Contributor Evaluation Policy and Payment-Period Conduct guidance; understand merge does not guarantee payment.
• Read CONTRIBUTING.md.
• cargo fmt clean on touched files.
• No new cargo clippy warnings.
• Tests added/updated, all pass (cargo test --lib: 180/180).
• Detailed traceability mapping filled out above (storage default fix + tests).
• Reviewed changes against the Reviewer Checklist.
• No new documentation or features imply regulatory completeness beyond smart contract enforcement.

Additional Context

$ cargo test --lib
test result: ok. 180 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

$ cargo build --release --target wasm32v1-none
Finished `release` profile [optimized] target(s)