AI-2128: Fix exception handling in sync_comment.py and install.sh#2
Open
RachelXiaolan wants to merge 1 commit into
Open
AI-2128: Fix exception handling in sync_comment.py and install.sh#2RachelXiaolan wants to merge 1 commit into
RachelXiaolan wants to merge 1 commit into
Conversation
Fixes in sync_comment.py: - Add FileNotFoundError handling when gh CLI is missing - Add TimeoutExpired handling for gh CLI calls - Return non-zero exit code when both comment platforms fail Fixes in install.sh: - Guard against missing --agent argument to prevent confusing errors
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linear Issue
https://linear.app/feedmob/issue/AI-2128
Summary
Two bugs found via source code audit (bug-hunting strategy B):
1. Missing exception handling in
github_comment()(scripts/sync_comment.py)subprocess.run()can raiseFileNotFoundErrorwhenghCLI is not installed (or not in PATH)subprocess.run()can raiseTimeoutExpiredafter 15s, but onlylinear_comment()had the try/except guard2. Missing argument guard in
install.sh--agentwith no following value silently consumes the next flag as the agent name, producing confusing errorsChanges
scripts/sync_comment.pyFileNotFoundErrorandTimeoutExpiredhandling togithub_comment();main()now returns exit code 1 when both platforms failinstall.sh--agentwithout argumentTest Plan
python3 scripts/sync_comment.pywith missing args shows usagegithub_comment()handles missing gh CLI gracefullyCloses [AI-2128]