-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ feat(components/drivers/): delete cputime #8119
base: master
Are you sure you want to change the base?
Conversation
because there is a bug(multithreading) and its function is duplicated with ktime/hrtimer
cputime和ktime是什么关系? |
内核最开始实现nanosleep等高精度的时候造的cputime,后面由于这个cputime的引入造成内核时间混乱(也不全是cputime的问题),我在梳理内核时间的时候,把cputime解耦(因为设计问题,存在多线程bug)出来,用ktime模块替换了 |
如果是这样,为什么不是增强cputime呢?否则一个轮子接着一个轮子在造的 |
也不是这么说,因为这个模块的名字就冲突了,cputime应该代指arm里面gtimer,riscv里面的mtimer这种cpu架构自带的定时器,而不是承担起一个高精度定时器的角色。 |
高精度定时,linux上的名称是叫hrtimer |
对于ktime来说,包括了cputimer,应该是包括了cputime(计时),而不是cputimer(定时器)。 |
ktime里面现在是cputimer(cpu定时器抽象层),hrtimer(高精度定时器)。这样就把以前的cputime的歧义纠正回来了 |
because there is a bug(multithreading) and its function is duplicated with ktime/hrtimer
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
删除cputime,因为其与ktime/hrtimer功能重复,且存在多线程下的bug
你的解决方案是什么 (what is your solution)
在什么测试环境下测试通过 (what is the test environment)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up