Skip to content

Conversation

@ache-hub
Copy link

@ache-hub ache-hub commented Oct 17, 2025

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

你的解决方案是什么 (what is your solution)

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@ache-hub ache-hub requested a review from kurisaW as a code owner October 17, 2025 00:38
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


ache seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions
Copy link

github-actions bot commented Oct 17, 2025

📌 Code Review Assignment

🏷️ Tag: bsp_cvitek

Reviewers: unicornx

Changed Files (Click to expand)
  • bsp/cvitek/.clang-format-ignore
  • bsp/cvitek/drivers/.ignore_format.yml

🏷️ Tag: bsp_hc32

Reviewers: levizh

Changed Files (Click to expand)
  • bsp/hc32/.clang-format-ignore
  • bsp/hc32/libraries/.ignore_format.yml
  • bsp/hc32l136/.clang-format-ignore
  • bsp/hc32l136/.ignore_format.yml
  • bsp/hc32l196/.clang-format-ignore

📊 Current Review Status (Last Updated: 2025-10-24 22:26 CST)

  • levizh Pending Review
  • unicornx Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions bot added BSP action github action yml imporve tools BSP: GD32 BSP related with GD32 BSP: Infineon BSP related with Infineon BSP: Cvitek BSP related with cvitek BSP: AT32 BSP related with AT32 labels Oct 17, 2025
@github-actions
Copy link

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:clang-format-ignore-migration
  • 设置PR number为 \ Set the PR number to:10829
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 clang-format-ignore-migration 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the clang-format-ignore-migration branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@unicornx
Copy link
Contributor

这个 PR 是干啥的,能否给点说明,或者有文档解释一下?

@ache-hub ache-hub force-pushed the clang-format-ignore-migration branch from 58b1f94 to 7eaebc4 Compare October 17, 2025 15:49
@ache-hub
Copy link
Author

Description

Migrate .ignore_format.yml to .clang-format-ignore mechanism for multiple BSPs

Changes

  • Replace .ignore_format.yml with .clang-format-ignore in all original locations
  • Update related scripts to use new mechanism
  • Remove all .ignore_format.yml files
  • Follow clang-format native ignore syntax rules

BSPs Completed:

  • acm32, apm32, at32, bouffalo_lab, core-v-mcu, cvitek
  • essemi, fm33lc026, ft32, gd32, hc32, hc32l136, hc32l196
  • hk32, hpmicro, ht32, Infineon

Scripts Updated:

  • tools/ci/file_check.py
  • tools/ci/format_ignore.py

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥要保留这些 backup 文件?我们不是有 git 吗?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥要保留这些 backup 文件?我们不是有 git 吗?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经删除.backup文件

@ache-hub ache-hub changed the title Clang format ignore migration #10764 RSOC:Clang format ignore migration #10764 Oct 20, 2025
@kurisaW
Copy link
Member

kurisaW commented Oct 20, 2025

tools/ci/format_ignore.py、tools/ci/file_check.py这两个是否本地运行测试通过?

@Rbb666
Copy link
Member

Rbb666 commented Oct 20, 2025

有一个冲突需要解决下,然后PR的标题修改下吧,写清楚这个PR修改了哪几个BSP

@kurisaW kurisaW changed the title RSOC:Clang format ignore migration #10764 format/rsoc:clang format ignore migration Oct 20, 2025
@Rbb666 Rbb666 linked an issue Oct 20, 2025 that may be closed by this pull request
@Rbb666 Rbb666 linked an issue Oct 21, 2025 that may be closed by this pull request
@github-actions github-actions bot added BSP: NXP Code related with NXP BSP: Renesas BSP related with Renesas BSP: Phytium BSP related with Phytium labels Oct 21, 2025
@ache-hub ache-hub changed the title format/rsoc:clang format ignore migration format/rsoc:clang format ignore migration(acm32,apm32,at32,bouffalo_lab,core-v-mcu,cvitek,esseml,fm33lc026,ft32,gd32,hc32,hc32l136,hc32l196,hk32,hpmicro,ht32,infineon)) Oct 21, 2025
@ache-hub ache-hub changed the title format/rsoc:clang format ignore migration(acm32,apm32,at32,bouffalo_lab,core-v-mcu,cvitek,esseml,fm33lc026,ft32,gd32,hc32,hc32l136,hc32l196,hk32,hpmicro,ht32,infineon)) format/rsoc:clang format ignore migration(acm32,apm32,at32,bouffalo_lab,core-v-mcu,cvitek,esseml,fm33lc026,ft32,gd32,hc32,hc32l136,hc32l196,hk32,hpmicro,ht32,infineon) Oct 21, 2025
@kurisaW kurisaW changed the title format/rsoc:clang format ignore migration(acm32,apm32,at32,bouffalo_lab,core-v-mcu,cvitek,esseml,fm33lc026,ft32,gd32,hc32,hc32l136,hc32l196,hk32,hpmicro,ht32,infineon) format/rsoc:clang format ignore migration Oct 21, 2025
@ache-hub ache-hub changed the title format/rsoc:clang format ignore migration format/rsoc:clang format ignore migration(acm32, apm32, at32, bouffalo_lab, core-v-mcu, cvitek essemi, fm33lc026, ft32, gd32, hc32, hc32l136, hc32l196 hk32, hpmicro, ht32, Infineon) Oct 21, 2025
@ache-hub ache-hub changed the title format/rsoc:clang format ignore migration(acm32, apm32, at32, bouffalo_lab, core-v-mcu, cvitek essemi, fm33lc026, ft32, gd32, hc32, hc32l136, hc32l196 hk32, hpmicro, ht32, Infineon) format/rsoc:clang format ignore migration Oct 21, 2025
@ache-hub ache-hub force-pushed the clang-format-ignore-migration branch from db29db5 to 0757944 Compare October 21, 2025 14:37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/arm/libraries下的GD32F10x_Firmware_Library这几个库都迁到软件包里了,这里的忽略脚本不需要了,可以自己多检查几遍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

瑞萨的几个脚本没有转换掉

@ache-hub ache-hub force-pushed the clang-format-ignore-migration branch from 0757944 to 8e3c9fb Compare October 24, 2025 14:26
@Rbb666 Rbb666 requested a review from kurisaW October 27, 2025 09:14
@Rbb666 Rbb666 merged commit 36bf8f6 into RT-Thread:master Oct 28, 2025
33 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve BSP: AT32 BSP related with AT32 BSP: Cvitek BSP related with cvitek BSP: GD32 BSP related with GD32 BSP: Infineon BSP related with Infineon BSP: NXP Code related with NXP BSP: Phytium BSP related with Phytium BSP: Renesas BSP related with Renesas BSP tools

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 5.2.2 版本需合并PR汇总 [Feature] 推动clang-format-ignore机制

5 participants