[components][net][lwip][port] 1.修复eth驱动层初始化失败导致lwip初始化不完整； #10810
Conversation
of the lwip layer was incomplete due to the failure of the eth driver layer initialization；
|
👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread! 为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 🛠 操作步骤 | Steps
完成后，提交将自动更新至 如有问题欢迎联系我们，再次感谢您的贡献！💐 |
📌 Code Review Assignment🏷️ Tag: componentsReviewers: @Maihuanyi Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-10-14 13:42 CST)
📝 Review Instructions
|
|
LGTM |
|
@Ryan-CW-Code 大佬可以协助审核下吗？谢谢 |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where ETH driver layer initialization failures prevent complete lwIP initialization. The solution moves device initialization and opening to occur after network interface setup (DHCP start, netif_set_up), allowing lwIP functionality to proceed even if the ETH driver fails initially.
Key Changes:
- Device initialization (
rt_device_initandrt_device_open) is moved from before netdev registration to after network interface setup - Netif flags assignment is changed from direct assignment (
=) to bitwise OR (|=) to preserve flags set during setup - These changes are applied consistently to both
eth_netif_device_initandaf_unix_eth_netif_device_initfunctions
| { | ||
| return ERR_IF; | ||
| } | ||
| if (rt_device_open(device, RT_DEVICE_FLAG_RDWR) != RT_EOK) | ||
| { |
There was a problem hiding this comment.
Bug: Returning ERR_IF after network interface is already set up (DHCP started, netif_set_up called) leaves the network stack in an inconsistent state. If device initialization fails at this point, the netif should be cleaned up or the error should be logged without terminating initialization.
错误：在网络接口已经设置完成（DHCP已启动，netif_set_up已调用）后返回ERR_IF会使网络栈处于不一致状态。如果此时设备初始化失败，应该清理netif或记录错误而不是终止初始化。
| { | |
| return ERR_IF; | |
| } | |
| if (rt_device_open(device, RT_DEVICE_FLAG_RDWR) != RT_EOK) | |
| { | |
| { | |
| /* Clean up netif if device init fails */ | |
| #if LWIP_DHCP | |
| dhcp_stop(netif); | |
| #endif | |
| netif_set_down(netif); | |
| LWIP_DEBUGF(NETIF_DEBUG, ("ethernetif_init: device init failed, cleaned up netif\n")); | |
| return ERR_IF; | |
| } | |
| if (rt_device_open(device, RT_DEVICE_FLAG_RDWR) != RT_EOK) | |
| { | |
| /* Clean up netif if device open fails */ | |
| #if LWIP_DHCP | |
| dhcp_stop(netif); | |
| #endif | |
| netif_set_down(netif); | |
| LWIP_DEBUGF(NETIF_DEBUG, ("ethernetif_init: device open failed, cleaned up netif\n")); |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
这样的目的是为网络协议栈和硬件分开初始化，当硬件的link状态改变后保证lwip功能完整；
| { | ||
| return ERR_IF; | ||
| } | ||
| if (rt_device_open(device, RT_DEVICE_FLAG_RDWR) != RT_EOK) | ||
| { |
There was a problem hiding this comment.
Bug: Same issue as Comment 1 - returning ERR_IF after netif_set_up leaves the network interface in an inconsistent state. This contradicts the PR's stated goal of allowing lwIP to function even when ETH driver initialization fails.
错误：与评论1相同的问题 - 在netif_set_up之后返回ERR_IF会使网络接口处于不一致状态。这与PR声明的"ETH驱动层初始化失败不影响lwip的功能"目标相矛盾。
| { | |
| return ERR_IF; | |
| } | |
| if (rt_device_open(device, RT_DEVICE_FLAG_RDWR) != RT_EOK) | |
| { | |
| { | |
| netif_set_down(netif); | |
| return ERR_IF; | |
| } | |
| if (rt_device_open(device, RT_DEVICE_FLAG_RDWR) != RT_EOK) | |
| { | |
| netif_set_down(netif); |
Copilot uses AI. Check for mistakes.
| { | ||
| return ERR_IF; | ||
| } | ||
| netif->flags |= (ethif->flags & 0xff); |
There was a problem hiding this comment.
Bug: Using |= operator after device initialization may incorrectly combine flags. If rt_device_init or rt_device_open modifies ethif->flags, this could set unintended flag bits. The original assignment at line 494 (netif->flags = (ethif->flags & 0xff)) should be removed to avoid setting flags twice with different operators.
错误：在设备初始化后使用|=运算符可能会错误地组合标志。如果rt_device_init或rt_device_open修改了ethif->flags，这可能会设置意外的标志位。应该删除第494行的原始赋值（netif->flags = (ethif->flags & 0xff)）以避免使用不同运算符两次设置标志。
Copilot uses AI. Check for mistakes.
| return ERR_IF; | ||
| } | ||
|
|
||
| netif->flags |= (ethif->flags & 0xff); |
There was a problem hiding this comment.
Bug: Same issue as Comment 3 - duplicate flag assignment with different operators. Line 682 sets netif->flags = (ethif->flags & 0xff) and line 730 uses |=, which may produce incorrect flag combinations.
错误：与评论3相同的问题 - 使用不同运算符重复赋值标志。第682行设置netif->flags = (ethif->flags & 0xff)，第730行使用|=，这可能产生错误的标志组合。
| netif->flags |= (ethif->flags & 0xff); | |
| /* netif->flags |= (ethif->flags & 0xff); -- removed duplicate assignment */ |
Copilot uses AI. Check for mistakes.
|
@Ryan-CW-Code 大佬可以看看这个PR吗？ |
| } | ||
|
|
||
| /* copy device flags to netif flags */ | ||
| netif->flags = (ethif->flags & 0xff); |
There was a problem hiding this comment.
佬，这部分可以延续你的思路，稍微更改一下，我没用过gd32，提供一个参考。
考虑到可能有其他 BSP 代码依赖 init 后的 flags 来配置 lwIP 的参数，我们尽量不要去改 lwIP port 层的逻辑。
在 GD32 上，可以模拟实现类似 STM32 ETH 驱动的效果，rt_device_init 阶段不直接调用 enet_init，而是只做 PHY、MAC 等不会触发链路状态检查的基础配置。
在 PHY 链路检测函数里，再判断 enet_init 是否已经执行过，如果还没有，就在链路 up 的时候补一次初始化。
3 participants
拉取/合并请求描述：(PR description)
[
你的解决方案是什么 (what is your solution)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up