-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[bsp/xuantie] 添加bsp导入rt-studio相关文件 #10728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds RT-Thread Studio project support for the xuantie BSP series by adding the necessary configuration files for Eclipse CDT integration. This enables developers to import these BSPs directly into RT-Studio for development.
- Adds RT-Studio project configuration files (
.project
,.settings
,projcfg.ini
) - Updates Kconfig files to use proper environment variable syntax for RT-Studio compatibility
- Adds pre-include header files (
rtconfig_preinc.h
) with platform-specific macro definitions
Reviewed Changes
Copilot reviewed 51 out of 60 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
Multiple rtconfig_preinc.h files |
Auto-generated header files with platform-specific macro definitions for RT-Thread configuration |
Multiple Kconfig files |
Updated configuration syntax from assignment to proper Kconfig format for RT-Studio compatibility |
Multiple .project files |
Eclipse CDT project configuration files for RT-Studio integration |
Multiple .settings/*.ini and .prefs files |
RT-Studio specific project settings and preferences |
bsp/xuantie/xiaohui/r910/rtconfig.py |
Updated path reference for tools directory |
bsp/xuantie/xiaohui/c908/rtconfig.py |
Removed Chinese comment |
#define CONFIG_SYSTICK_HZ 100 | ||
#define CONFIG_VIC_TSPDR 201326592 | ||
#define CONFIG_XIP 1 | ||
#define DCONFIG_CPU_XUANTIE_C906FD 1 |
Copilot
AI
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug/错误: Missing 'C' prefix in macro name. Should be 'CONFIG_CPU_XUANTIE_C906FD' not 'DCONFIG_CPU_XUANTIE_C906FD'.
中文:宏定义名称缺少'C'前缀。应该是'CONFIG_CPU_XUANTIE_C906FD'而不是'DCONFIG_CPU_XUANTIE_C906FD'。
#define DCONFIG_CPU_XUANTIE_C906FD 1 | |
#define CONFIG_CPU_XUANTIE_C906FD 1 |
Copilot uses AI. Check for mistakes.
import sys | ||
cwd_path = os.getcwd() | ||
sys.path.append(os.path.join(os.path.dirname(BSP_ROOT), 'tools')) | ||
sys.path.append(os.path.join(os.path.dirname(BSP_ROOT), '../tools')) |
Copilot
AI
Sep 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug/错误: Incorrect path construction. Using '../tools' with dirname(BSP_ROOT) creates an invalid path. Should be 'tools' instead of '../tools'.
中文:路径构造错误。在dirname(BSP_ROOT)基础上使用'../tools'会创建无效路径。应该使用'tools'而不是'../tools'。
sys.path.append(os.path.join(os.path.dirname(BSP_ROOT), '../tools')) | |
sys.path.append(os.path.join(os.path.dirname(BSP_ROOT), 'tools')) |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MuChenger 这个文件不用提交上来,这个是studio自动生成的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rtconfig_preinc.h文件如果想要bsp导入studio后直接编译的话,其实还是需要保留的,否则用户就必须先执行一遍scons同步生成rtconfig_preinc.h,看从用户使用便利性的角度要不要保留吧(有些用户并不懂为什么会有个libc的报错是因为要先执行scons同步后生成宏定义)
后续可以论坛或者文档中心中,加一些文档如何使用。或者doc中加一些说明如何使用。 |
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up