-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[action/ci] add qemu-pre-build-and-post-build for RT_SMART build #10203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f7ee341
to
eb142ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new QEMU automated testing functionality to verify BSP builds using qemu-vexpress-a9. Key changes include:
- Addition of a QemuManager class for process control and log monitoring.
- Integration of QEMU command execution into the BSP build flow.
- Updates to the ci.attachconfig.yml file to support new QEMU test configurations.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tools/ci/bsp_buildings.py | Introduces QemuManager and integrates QEMU test logic into BSP build process. |
bsp/qemu-vexpress-a9/.ci/attachconfig/ci.attachconfig.yml | Adds new YAML configuration for QEMU automation. |
Comments suppressed due to low confidence (1)
tools/ci/bsp_buildings.py:294
- [nitpick] Consider adding a clear separator or rephrasing the error message to improve readability, for example inserting a colon or space between the check_string and the output.
print('::error:: can not find string ' + check_string + output)
5763ecf
to
567f2b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the CI process by adding pre-build and post-build command execution, environment variable setting support, and build output verification for multiple toolchains and BSPs including RT_SMART builds. Key changes include:
- Extending the build_bsp function to accept pre-build and post-build commands, a build output check, and BSP-specific environment variables.
- Adding logic to load and apply configuration from YAML files for both standard and RT_SMART builds.
- Updating the GitHub Actions workflow to install Arm Musl toolchains when required.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
tools/ci/bsp_buildings.py | Added support for pre-build/post-build commands, environment setting, and build output verification. |
bsp/qemu-vexpress-a9/.ci/attachconfig/ci.attachconfig.yml | Updated YAML config to support RT_SMART builds with new kconfig and env settings. |
.github/workflows/bsp_buildings.yml | Introduced a new job step to install Arm Musl toolchains. |
Comments suppressed due to low confidence (1)
tools/ci/bsp_buildings.py:293
- There is a spelling mistake in the variable name 'config_bacakup'. It should be renamed to 'config_backup' for clarity.
config_bacakup = config_file+'.origin'
0adf1e9
to
3231b75
Compare
f82ddca
to
aa3fe31
Compare
aa3fe31
to
a88df8c
Compare
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
添加qemu-vexpress-a9的编译前的执行脚本,和编译后的执行脚本,
添加smart的配置,添加yml中的环境变量的设置,目前ci可以支持多种toolchain的编译同一个bsp
你的解决方案是什么 (what is your solution)
添加yml中的配置
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up