Rtt riscv rust support #12

foxg1ove1 · 2025-09-30T02:40:58Z

- Replace non-ASCII characters (✓/✗) with ASCII equivalents - Remove non-existent libc::access function calls - Fix array size mismatch by using &[&[u8]] slice type

BernardXiong · 2025-10-13T08:48:02Z

.gitmodules

 [submodule "rt-thread"]
 	path = rt-thread
-	url = https://github.com/RT-Thread/rt-thread.git
+	url = git@github.com:RT-Thread/rt-thread.git


这个文件应该不需要修改，依然保留https模式即可

machines/qemu-virt-riscv64/rust/core/src/api/base.rs

BernardXiong · 2025-10-14T02:30:37Z

machines/qemu-virt-riscv64/rust/README.md

+## Project Structure
+
+```
+rust/


需要对当前目录情况进行update

BernardXiong · 2025-10-14T02:36:39Z

machines/qemu-virt-riscv64/rust/README.md

+## Project Structure
+
+```
+rust/


需要对当前目录情况进行update

machines/qemu-virt-riscv64/rust/core/src/api/base.rs

BernardXiong · 2025-10-19T03:05:47Z

machines/qemu-virt-riscv64/applications/c_bench.c

@@ -0,0 +1,19 @@
+// #include <stdio.h>


多看看RT-Thread的编程规范，不应该有这样都是注释掉的代码的，需要遵循对应的风格：

简洁，代码清晰；

代码上不多一行代码，不少一行代码；

BernardXiong · 2025-10-19T03:06:51Z

machines/qemu-virt-riscv64/mylib/target/.rustc_info.json

@@ -0,0 +1 @@
+{"rustc_fingerprint":4312154744837725510,"outputs":{"17747080675513052775":{"success":true,"status":"","code":0,"stdout":"rustc 1.90.0-nightly (4b55fe199 2025-08-01)\nbinary: rustc\ncommit-hash: 4b55fe199cfe9c710555a5af7f2a49491ad38254\ncommit-date: 2025-08-01\nhost: x86_64-unknown-linux-gnu\nrelease: 1.90.0-nightly\nLLVM version: 20.1.8\n","stderr":""},"7971740275564407648":{"success":true,"status":"","code":0,"stdout":"___\nlib___.rlib\nlib___.so\nlib___.so\nlib___.a\nlib___.so\n/home/fox/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu\noff\npacked\nunpacked\n___\ndebug_assertions\nfmt_debug=\"full\"\noverflow_checks\npanic=\"unwind\"\nproc_macro\nrelocation_model=\"pic\"\ntarget_abi=\"\"\ntarget_arch=\"x86_64\"\ntarget_endian=\"little\"\ntarget_env=\"gnu\"\ntarget_family=\"unix\"\ntarget_feature=\"fxsr\"\ntarget_feature=\"sse\"\ntarget_feature=\"sse2\"\ntarget_feature=\"x87\"\ntarget_has_atomic\ntarget_has_atomic=\"16\"\ntarget_has_atomic=\"32\"\ntarget_has_atomic=\"64\"\ntarget_has_atomic=\"8\"\ntarget_has_atomic=\"ptr\"\ntarget_has_atomic_equal_alignment=\"16\"\ntarget_has_atomic_equal_alignment=\"32\"\ntarget_has_atomic_equal_alignment=\"64\"\ntarget_has_atomic_equal_alignment=\"8\"\ntarget_has_atomic_equal_alignment=\"ptr\"\ntarget_has_atomic_load_store\ntarget_has_atomic_load_store=\"16\"\ntarget_has_atomic_load_store=\"32\"\ntarget_has_atomic_load_store=\"64\"\ntarget_has_atomic_load_store=\"8\"\ntarget_has_atomic_load_store=\"ptr\"\ntarget_has_reliable_f128\ntarget_has_reliable_f16\ntarget_has_reliable_f16_math\ntarget_os=\"linux\"\ntarget_pointer_width=\"64\"\ntarget_thread_local\ntarget_vendor=\"unknown\"\nub_checks\nunix\n","stderr":""},"1001216461566314707":{"success":true,"status":"","code":0,"stdout":"___\nlib___.rlib\nlib___.so\nlib___.so\nlib___.a\nlib___.so\n/home/fox/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu\noff\n___\ndebug_assertions\nfmt_debug=\"full\"\noverflow_checks\npanic=\"abort\"\nproc_macro\nrelocation_model=\"pic\"\ntarget_abi=\"\"\ntarget_arch=\"riscv64\"\ntarget_endian=\"little\"\ntarget_env=\"gnu\"\ntarget_family=\"unix\"\ntarget_feature=\"a\"\ntarget_feature=\"c\"\ntarget_feature=\"d\"\ntarget_feature=\"f\"\ntarget_feature=\"m\"\ntarget_feature=\"zaamo\"\ntarget_feature=\"zalrsc\"\ntarget_feature=\"zicsr\"\ntarget_feature=\"zifencei\"\ntarget_has_atomic\ntarget_has_atomic=\"16\"\ntarget_has_atomic=\"32\"\ntarget_has_atomic=\"64\"\ntarget_has_atomic=\"8\"\ntarget_has_atomic=\"ptr\"\ntarget_has_atomic_equal_alignment=\"16\"\ntarget_has_atomic_equal_alignment=\"32\"\ntarget_has_atomic_equal_alignment=\"64\"\ntarget_has_atomic_equal_alignment=\"8\"\ntarget_has_atomic_equal_alignment=\"ptr\"\ntarget_has_atomic_load_store\ntarget_has_atomic_load_store=\"16\"\ntarget_has_atomic_load_store=\"32\"\ntarget_has_atomic_load_store=\"64\"\ntarget_has_atomic_load_store=\"8\"\ntarget_has_atomic_load_store=\"ptr\"\ntarget_has_reliable_f128\ntarget_has_reliable_f128_math\ntarget_has_reliable_f16\ntarget_has_reliable_f16_math\ntarget_os=\"linux\"\ntarget_pointer_width=\"64\"\ntarget_thread_local\ntarget_vendor=\"unknown\"\nub_checks\nunix\n","stderr":""}},"successes":{}}


请仔细查看提及的PR，不多一个文件，不少一个文件。这样杂乱无章的代码提交，也是不可能进行合并的。

Copilot

Pull Request Overview

This PR adds comprehensive Rust support for RT-Thread on RISC-V 64-bit platforms, enabling embedded Rust development with automatic architecture detection, component management, and example applications.

Implements Rust bindings and wrappers for RT-Thread kernel APIs (threads, mutexes, semaphores, queues, filesystem, dynamic loading)
Provides automatic target architecture detection for ARM, AArch64, and RISC-V with floating-point ABI support
Includes example user applications, components, and dynamic libraries with unified component registration architecture

Reviewed Changes

Copilot reviewed 84 out of 97 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
machines/qemu-virt-riscv64/rust/tools/build_support.py	Python build utilities for Rust target detection and cargo integration
machines/qemu-virt-riscv64/rust/src/*.rs	Core Rust API wrappers for RT-Thread primitives and system calls
machines/qemu-virt-riscv64/rust/macro-main/src/lib.rs	Procedural macro for no_std main function entry point generation
machines/qemu-virt-riscv64/example_usrapp/*	Example user applications demonstrating threads, mutexes, queues, filesystem
machines/qemu-virt-riscv64/example_component/*	Component registry and logging component with feature-based conditional compilation
machines/qemu-virt-riscv64/rust/Kconfig	RT-Thread configuration options for Rust support

Comments suppressed due to low confidence (1)

machines/qemu-virt-riscv64/rust/src/fs.rs:1

Incorrect notes text - should describe file operation functionality, not 'micro rust log component'. Consider: 'Rust file operation wrapper'.

/*

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-24T17:06:31Z

machines/qemu-virt-riscv64/rust/core/src/sem.rs

+    pub fn release(&self) {
+        semaphore_release(self.sem);
+    }
+


The drop method has incorrect signature and visibility. It should be part of a Drop trait implementation. This method will never be called as a destructor. Replace with impl Drop for Semaphore and make drop lowercase as fn drop(&mut self).

Suggested change

}

impl Drop for Semaphore {

Copilot · 2025-10-24T17:06:31Z

machines/qemu-virt-riscv64/rust/core/src/libloader.rs

+
+/// Print the last libdl error using RT-Thread `printf`.
+pub fn dl_print_last_error() {
+    // 使用 println! 更符合当前输出宏


[nitpick] Comment contains mixed language content. For consistency in an English codebase, translate Chinese comment to English: 'Using println! is more appropriate for current output macro'.

Suggested change

// 使用 println! 更符合当前输出宏

// Using println! is more appropriate for current output macro

@foxg1ove1 代码注释请使用英文。

Copilot · 2025-10-24T17:06:32Z

machines/qemu-virt-riscv64/rust/core/src/api/libloading.rs

+            Ok(())
+        } else {
+            Err(DlError::Close(rc))
+        }


The condition logic is inverted. dlclose returns 0 on success and non-zero on error according to POSIX standard. Should be if rc == 0 { Ok(()) } else { Err(DlError::Close(rc)) }.

@foxg1ove1 这里应该是bug，请进行修正。

// rt-thread/components/libc/posix/libdl/dlclose.c int dlclose(void *handle) { struct rt_dlmodule *module; RT_ASSERT(handle != RT_NULL); module = (struct rt_dlmodule *)handle; rt_enter_critical(); module->nref--; if (module->nref <= 0) { rt_exit_critical(); dlmodule_destroy(module); } else { rt_exit_critical(); } return RT_TRUE; } // rt-thread/include/rttypes.h #define RT_TRUE 1

封装的 dlclose 函数为 pub fn dlclose(handle: *mut c_void) -> c_int; ，所以 rc == 1 为成功而不是 rc == 0

Copilot · 2025-10-24T17:06:32Z

machines/qemu-virt-riscv64/rust/macro-main/src/lib.rs

+    if arg.name.is_none() {
+        return parse::Error::new(
+            Span::call_site(),
+            "`#[marco_main_use]` macro must have attribute `name`",


Typo in error message: 'marco' should be 'macro'.

Suggested change

"`#[marco_main_use]` macro must have attribute `name`",

"`#[macro_main_use]` macro must have attribute `name`",

Copilot · 2025-10-24T17:06:33Z

machines/qemu-virt-riscv64/rust/tools/build_support.py

+        return "riscv32imafc-unknown-none-elf" if ("f" in cflags or "d" in cflags) else "riscv32imac-unknown-none-elf"
+    if "-march=rv64" in cflags:
+        if ("-mabi=lp64d" in cflags) or ("-mabi=lp64f" in cflags) or ("f" in cflags) or ("d" in cflags):


The substring checks 'f' in cflags and 'd' in cflags will match unintended flags like '-ffunction-sections'. Should check for -march= flag parsing instead or use more specific patterns like checking if 'f' or 'd' appears in the march value extracted earlier.

Suggested change

return "riscv32imafc-unknown-none-elf" if ("f" in cflags or "d" in cflags) else "riscv32imac-unknown-none-elf"

if "-march=rv64" in cflags:

if ("-mabi=lp64d" in cflags) or ("-mabi=lp64f" in cflags) or ("f" in cflags) or ("d" in cflags):

march_val = None

mabi_val = None

for flag in cflags.split():

if flag.startswith("-march="):

march_val = flag[len("-march="):]

elif flag.startswith("-mabi="):

mabi_val = flag[len("-mabi="):]

has_f_or_d = False

if march_val and any(x in march_val for x in ("f", "d")):

has_f_or_d = True

if mabi_val and any(x in mabi_val for x in ("f", "d")):

has_f_or_d = True

return "riscv32imafc-unknown-none-elf" if has_f_or_d else "riscv32imac-unknown-none-elf"

if "-march=rv64" in cflags:

march_val = None

mabi_val = None

for flag in cflags.split():

if flag.startswith("-march="):

march_val = flag[len("-march="):]

elif flag.startswith("-mabi="):

mabi_val = flag[len("-mabi="):]

has_f_or_d = False

if mabi_val and (("lp64d" in mabi_val) or ("lp64f" in mabi_val)):

has_f_or_d = True

if march_val and any(x in march_val for x in ("f", "d")):

has_f_or_d = True

if mabi_val and any(x in mabi_val for x in ("f", "d")):

has_f_or_d = True

if has_f_or_d:

BernardXiong · 2025-10-24T23:50:52Z

目录结构部分可以参照下 #14 的情况，当前PR的目录结构稍显乱了些。

- Remove target/rust-analyzer/flycheck0/stderr and stdout files - Add Rust-related ignore patterns to .gitignore - Prevent rust-analyzer temporary files from being tracked

Copilot

Pull Request Overview

Copilot reviewed 89 out of 92 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-29T11:42:18Z

machines/qemu-virt-riscv64/rust/core/src/bindings/mod.rs

+pub mod libc;
+pub mod librt;
+
+ pub use librt::*;


Glob re-export from librt at the module level can lead to namespace pollution and makes it unclear which symbols are available. Consider explicitly re-exporting only the needed types/functions or use the glob only in a prelude module.

Suggested change

pub use librt::*;

// Explicitly re-export only the needed items from librt to avoid namespace pollution.

// Example: pub use librt::{item1, item2, item3};

// TODO: Replace with actual items needed from librt.

// pub use librt::{item1, item2};

Copilot · 2025-10-29T11:42:19Z

machines/qemu-virt-riscv64/rust/core/src/panic.rs

+/// that can be overridden by external code.
+#[linkage = "weak"]
+#[unsafe(no_mangle)]
+fn __rust_panic() -> ! {


The weak panic handler loops forever without any indication. Consider adding a comment explaining that this is intentional behavior for the default weak implementation, or add a debug output if possible before entering the infinite loop.

Suggested change

fn __rust_panic() -> ! {

fn __rust_panic() -> ! {

// Default weak panic handler: intentionally loops forever to halt execution.

// Override this function for custom panic behavior.

print!("Entered weak panic handler: system will halt.");

Copilot · 2025-10-29T11:42:19Z

machines/qemu-virt-riscv64/rust/core/src/fs.rs

+ *
+ * Change Logs:
+ * Date           Author       notes
+ * 2025-10-10     foxglove     micro rust log component


The change log comment 'micro rust log component' doesn't match the file purpose. This is the filesystem module, not a log component. The comment should describe filesystem operations.

Suggested change

* 2025-10-10 foxglove micro rust log component

* 2025-10-10 foxglove initial filesystem module implementation

Copilot · 2025-10-29T11:42:19Z

machines/qemu-virt-riscv64/rust/docs/4.modules/modules-readme_cn.md

+
+```toml
+[build]
+target = "your_target


Missing closing quote. Should be target = \"your_target\".

Copilot · 2025-10-29T11:42:20Z

machines/qemu-virt-riscv64/rust/tools/build_support.py

+        # ARM Cortex-M
+    if has("ARCH_ARM"):


The comment '# ARM Cortex-M' is misaligned with the if statement below it. The indentation suggests the comment belongs to the function docstring above, but semantically it describes the if block. Fix the indentation to align the comment with the if statement.

Copilot · 2025-10-29T11:42:20Z

machines/qemu-virt-riscv64/rust/tools/build_support.py

+        # ABI must carry f/d to actually use hard-float calling convention
+        abi = info["mabi"] or ""
+        abi_has_fp = abi.endswith("f") or abi.endswith("d")
+        has_fpu = has("ARCH_RISCV_FPU") or has("ENABLE_FPU") or info["has_f"] or info["has_d"]


Variable has_fpu is not used.

Copilot · 2025-10-29T11:42:20Z

machines/qemu-virt-riscv64/rust/tools/build_usrapp.py

+
+        # List all files in the directory for debugging
+        try:
+            files = os.listdir(search_path)


Variable files is not used.

BernardXiong · 2025-10-24T22:50:01Z

.gitmodules

 [submodule "rt-thread"]
 	path = rt-thread
-	url = https://github.com/RT-Thread/rt-thread.git
+	url = git@github.com:RT-Thread/rt-thread.git


这里可以不用修改的。

BernardXiong · 2025-10-24T22:50:27Z

machines/qemu-virt-riscv64/.config

@@ -1,1448 +0,0 @@
-


这个文件为什么会被删除掉？

BernardXiong · 2025-10-29T11:42:36Z

machines/qemu-virt-riscv64/rust/core/src/api/libloading.rs

+            Ok(())
+        } else {
+            Err(DlError::Close(rc))
+        }


@foxg1ove1 这里应该是bug，请进行修正。

BernardXiong · 2025-10-29T11:43:34Z

machines/qemu-virt-riscv64/rust/core/src/libloader.rs

+
+/// Print the last libdl error using RT-Thread `printf`.
+pub fn dl_print_last_error() {
+    // 使用 println! 更符合当前输出宏


@foxg1ove1 代码注释请使用英文。

foxg1ove1 added 11 commits September 30, 2025 00:59

update config of git

8f271f9

新建rust项目架构，包括项目编译脚本、config配置以及rust编译配置

ed5cd4c

增加新模块，包括string、memory和thread等实现

76110e8

补充配置文件

e7b9b67

新增动态加载模块

684ebd2

动态加载模块

7884895

完善脚本和文档说明

6ed3785

email填写

aafa522

不重要的修改

ea6ea82

补全基本接口

55c0dd4

Fix compilation errors in dlmodule_demo.rs

1d21348

- Replace non-ASCII characters (✓/✗) with ASCII equivalents - Remove non-existent libc::access function calls - Fix array size mismatch by using &[&[u8]] slice type

BernardXiong reviewed Oct 14, 2025

View reviewed changes

更成熟的libload封装，同时添加了bench测试

42e3b4a

BernardXiong reviewed Oct 19, 2025

View reviewed changes

foxg1ove1 added 5 commits October 19, 2025 17:12

修改了项目结构，增加了macro-main便于用户使用

4703ab5

恢复RT-Thread config配置

bdd34b0

删去不使用的函数

c9f068b

rust debug模式

7bac9b3

删去不必要的代码

a016a8b

foxg1ove1 changed the base branch from rust to main October 21, 2025 01:35

foxg1ove1 added 9 commits October 21, 2025 10:08

重命名rust库

83f236f

设置.gitignore

e8da6e2

修复了一些线程的bug

d449a40

添加macro-main注册组件功能，并使用logging测试

090c74d

删除不需要的文件

3bca57d

完善macro-main

7315a3b

增加文件操作

737ac0b

增加macro-main说明

74c4386

增加日志组件测试，分离应用与组件

a1a7234

改变组件注册方式

c34ea9e

BernardXiong requested a review from Copilot October 24, 2025 17:05

Copilot AI reviewed Oct 24, 2025

View reviewed changes

BernardXiong mentioned this pull request Oct 24, 2025

当加入rust组件支持时的目录结构 #13

Open

Copilot AI mentioned this pull request Oct 24, 2025

Add Rust component directory structure design proposal for RT-Thread #14

Draft

foxg1ove1 added 11 commits October 25, 2025 16:32

配置.gitignore

b4355aa

恢复初始配置

3fd0715

解决合并冲突：保留 Kconfig 文件

8da8444

恢复applications

97aac92

恢复./gitmodules

f2b7230

配置 .gitignore：忽略 .config, Kconfig, link.lds, rtconfig.h, rtconfig.py

140278e

./gitignore Kconfig

989d3b1

集成examples

82b549d

解耦合过程宏，分解各种功能的rust形式export

dc04dae

Remove rust-analyzer temporary files and update .gitignore

2eb6fd2

- Remove target/rust-analyzer/flycheck0/stderr and stdout files - Add Rust-related ignore patterns to .gitignore - Prevent rust-analyzer temporary files from being tracked

重命名core组件

d39848b

BernardXiong requested a review from Copilot October 29, 2025 11:39

Copilot AI reviewed Oct 29, 2025

View reviewed changes

BernardXiong reviewed Oct 29, 2025

View reviewed changes

修复小bug、注释

e75bcf6

		@@ -0,0 +1 @@
		{"rustc_fingerprint":4312154744837725510,"outputs":{"17747080675513052775":{"success":true,"status":"","code":0,"stdout":"rustc 1.90.0-nightly (4b55fe199 2025-08-01)\nbinary: rustc\ncommit-hash: 4b55fe199cfe9c710555a5af7f2a49491ad38254\ncommit-date: 2025-08-01\nhost: x86_64-unknown-linux-gnu\nrelease: 1.90.0-nightly\nLLVM version: 20.1.8\n","stderr":""},"7971740275564407648":{"success":true,"status":"","code":0,"stdout":"___\nlib___.rlib\nlib___.so\nlib___.so\nlib___.a\nlib___.so\n/home/fox/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu\noff\npacked\nunpacked\n___\ndebug_assertions\nfmt_debug=\"full\"\noverflow_checks\npanic=\"unwind\"\nproc_macro\nrelocation_model=\"pic\"\ntarget_abi=\"\"\ntarget_arch=\"x86_64\"\ntarget_endian=\"little\"\ntarget_env=\"gnu\"\ntarget_family=\"unix\"\ntarget_feature=\"fxsr\"\ntarget_feature=\"sse\"\ntarget_feature=\"sse2\"\ntarget_feature=\"x87\"\ntarget_has_atomic\ntarget_has_atomic=\"16\"\ntarget_has_atomic=\"32\"\ntarget_has_atomic=\"64\"\ntarget_has_atomic=\"8\"\ntarget_has_atomic=\"ptr\"\ntarget_has_atomic_equal_alignment=\"16\"\ntarget_has_atomic_equal_alignment=\"32\"\ntarget_has_atomic_equal_alignment=\"64\"\ntarget_has_atomic_equal_alignment=\"8\"\ntarget_has_atomic_equal_alignment=\"ptr\"\ntarget_has_atomic_load_store\ntarget_has_atomic_load_store=\"16\"\ntarget_has_atomic_load_store=\"32\"\ntarget_has_atomic_load_store=\"64\"\ntarget_has_atomic_load_store=\"8\"\ntarget_has_atomic_load_store=\"ptr\"\ntarget_has_reliable_f128\ntarget_has_reliable_f16\ntarget_has_reliable_f16_math\ntarget_os=\"linux\"\ntarget_pointer_width=\"64\"\ntarget_thread_local\ntarget_vendor=\"unknown\"\nub_checks\nunix\n","stderr":""},"1001216461566314707":{"success":true,"status":"","code":0,"stdout":"___\nlib___.rlib\nlib___.so\nlib___.so\nlib___.a\nlib___.so\n/home/fox/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu\noff\n___\ndebug_assertions\nfmt_debug=\"full\"\noverflow_checks\npanic=\"abort\"\nproc_macro\nrelocation_model=\"pic\"\ntarget_abi=\"\"\ntarget_arch=\"riscv64\"\ntarget_endian=\"little\"\ntarget_env=\"gnu\"\ntarget_family=\"unix\"\ntarget_feature=\"a\"\ntarget_feature=\"c\"\ntarget_feature=\"d\"\ntarget_feature=\"f\"\ntarget_feature=\"m\"\ntarget_feature=\"zaamo\"\ntarget_feature=\"zalrsc\"\ntarget_feature=\"zicsr\"\ntarget_feature=\"zifencei\"\ntarget_has_atomic\ntarget_has_atomic=\"16\"\ntarget_has_atomic=\"32\"\ntarget_has_atomic=\"64\"\ntarget_has_atomic=\"8\"\ntarget_has_atomic=\"ptr\"\ntarget_has_atomic_equal_alignment=\"16\"\ntarget_has_atomic_equal_alignment=\"32\"\ntarget_has_atomic_equal_alignment=\"64\"\ntarget_has_atomic_equal_alignment=\"8\"\ntarget_has_atomic_equal_alignment=\"ptr\"\ntarget_has_atomic_load_store\ntarget_has_atomic_load_store=\"16\"\ntarget_has_atomic_load_store=\"32\"\ntarget_has_atomic_load_store=\"64\"\ntarget_has_atomic_load_store=\"8\"\ntarget_has_atomic_load_store=\"ptr\"\ntarget_has_reliable_f128\ntarget_has_reliable_f128_math\ntarget_has_reliable_f16\ntarget_has_reliable_f16_math\ntarget_os=\"linux\"\ntarget_pointer_width=\"64\"\ntarget_thread_local\ntarget_vendor=\"unknown\"\nub_checks\nunix\n","stderr":""}},"successes":{}} No newline at end of file

	// 使用 println! 更符合当前输出宏
	// Using println! is more appropriate for current output macro

	"`#[marco_main_use]` macro must have attribute `name`",
	"`#[macro_main_use]` macro must have attribute `name`",

-        return "riscv32imafc-unknown-none-elf" if ("f" in cflags or "d" in cflags) else "riscv32imac-unknown-none-elf"
-    if "-march=rv64" in cflags:
-        if ("-mabi=lp64d" in cflags) or ("-mabi=lp64f" in cflags) or ("f" in cflags) or ("d" in cflags):
+        march_val = None
+        mabi_val = None
+        for flag in cflags.split():
+            if flag.startswith("-march="):
+                march_val = flag[len("-march="):]
+            elif flag.startswith("-mabi="):
+                mabi_val = flag[len("-mabi="):]
+        has_f_or_d = False
+        if march_val and any(x in march_val for x in ("f", "d")):
+            has_f_or_d = True
+        if mabi_val and any(x in mabi_val for x in ("f", "d")):
+            has_f_or_d = True
+        return "riscv32imafc-unknown-none-elf" if has_f_or_d else "riscv32imac-unknown-none-elf"
+    if "-march=rv64" in cflags:
+        march_val = None
+        mabi_val = None
+        for flag in cflags.split():
+            if flag.startswith("-march="):
+                march_val = flag[len("-march="):]
+            elif flag.startswith("-mabi="):
+                mabi_val = flag[len("-mabi="):]
+        has_f_or_d = False
+        if mabi_val and (("lp64d" in mabi_val) or ("lp64f" in mabi_val)):
+            has_f_or_d = True
+        if march_val and any(x in march_val for x in ("f", "d")):
+            has_f_or_d = True
+        if mabi_val and any(x in mabi_val for x in ("f", "d")):
+            has_f_or_d = True
+        if has_f_or_d:

- pub use librt::*;
+// Explicitly re-export only the needed items from librt to avoid namespace pollution.
+// Example: pub use librt::{item1, item2, item3};
+// TODO: Replace with actual items needed from librt.
+// pub use librt::{item1, item2};

-fn __rust_panic() -> ! {
+fn __rust_panic() -> ! {
+    // Default weak panic handler: intentionally loops forever to halt execution.
+    // Override this function for custom panic behavior.
+    print!("Entered weak panic handler: system will halt.");

	* 2025-10-10 foxglove micro rust log component
	* 2025-10-10 foxglove initial filesystem module implementation

Uh oh!

Rtt riscv rust support #12

Are you sure you want to change the base?

Rtt riscv rust support #12

Conversation

foxg1ove1 commented Sep 30, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 24, 2025

Choose a reason for hiding this comment

Uh oh!

BernardXiong commented Oct 24, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!