-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
SDL: Add DS3 button pressure #16848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL: Add DS3 button pressure #16848
Conversation
3f6195f
to
dbd28d8
Compare
I know it's still a draft but tried it and thought I'd mention the behavior so far:
That's all, really appreciate you working on this, Megamouse 🙂 |
1a079d9
to
475a99d
Compare
This works now! The SDL implementation is a bit strange, but whatever... |
You work fast! Was going to report earlier that simply pressing was giving no input (but hard pressing did) and in the middle of compressing the video I saw a new push and was glad to see that it works now. However there's still a minor hiccup that can occur while going from regular to full press, check the following vid (this is from the latest commit, starts at 0:04): 2025-04-10.21-02-56.trimmed.trimmed.mp4I'm just pressing harder / loosening it but never letting go, again something minor but thought I'd report it. Amazing work Megamouse, thanks again 🙏🏻 |
@ItsLaguna can you try again ? |
@Megamouse working perfectly now, no more hiccups but comparing between DS3 handler and the current SDL I've noticed you gotta push a bit more than usual. 2025-04-10.22-15-52.trimmed.mp4Here I'm switching between both and as you can see it goes back to the other regular press despite applying the same amount of force to the button. |
I know. but that's just how SDL reports the value... |
Ah that's a shame, hopefully they can sort that out. |
e19f0a4
to
f88ef45
Compare
Turns out I was dropping negative values, which means the whole weaker half of the button press. |
Yeah, now it matches 👍🏻 Noticed that upon changing handlers, there's a weird input (R1+Triangle?) but honestly no one is going to be doing that. 2025-04-10.23-01-42.mp4 |
26f3fdb
to
5f58c17
Compare
I couldn't reproduce this. Maybe it's specific to mgs. |
This seems very hacky, but it's supposedly the only way to make it work.
The code changes are inspired by non-existent documentation and some bold PRs in other projects.
NOTE: It won't work on windows, since our CI builds SDL without hidapi support.
Fixes #16824