Skip to content

Postprocess CE fix#147

Merged
victorventuri merged 4 commits intomainfrom
postprocess_CE_fix
Aug 19, 2025
Merged

Postprocess CE fix#147
victorventuri merged 4 commits intomainfrom
postprocess_CE_fix

Conversation

@victorventuri
Copy link
Contributor

Minor fixes to computation of CE adjusted charge, with new, more descriptive name, for the corresponding column. Also fixes a couple of warnings that would arise when adding a new column to an existing dataframe.

The way pandas deals with the addition of new columns is a bit weird, as there
is a difference between a view of a dataframe, a copy of it, and the dataframe
itself. By using `.loc` with a specified tuple of new columns to add, we do what
pandas deems correct, and circumvent several annoying warnings
The CE-adjusted charge column has a new, more descriptive name.
@coveralls
Copy link

coveralls commented Aug 19, 2025

Pull Request Test Coverage Report for Build 17080729821

Details

  • 8 of 8 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 95.971%

Totals Coverage Status
Change from base Build 16978801870: -0.003%
Covered Lines: 1310
Relevant Lines: 1365

💛 - Coveralls

@victorventuri victorventuri merged commit 19961e6 into main Aug 19, 2025
5 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants