Conversation
Changing the ChargingState schema from 'hold' to 'rest' caused a number of issues, which should now have been fixed.
The way to assign the simpler control methods is more streamlined. Short rests are tied only to their duration, independently of how many data points are present. Other short steps are classified as either pulses if they have >=5 data points, or short non-rests, in case there are <5 data points. Non-rest steps that last longer than 30 seconds but have fewer than 5 datapoints are considered unknown control method.
When computing the control method, we now allow the user to specify what they wish to consider is a short enough period to be classified as short rest, pulse, or short non-rest. That value defaults to 30 seconds, as originally intended.
Included additional explanation for some of the pre-specified control methods.
Now, the StateOfCharge RawDataEnhancer takes into account Coulombic Efficiency, and outputs a third column to the raw dataframe, that of the CE adjusted charge, meaning, the actual charge in the battery, rather than the one observed by the cycler. It defaults to 1.0 (100% efficiency), so, by default, this new column is equivalent to the `'cycled_charge'` column.
Pull Request Test Coverage Report for Build 16947064754Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small changes to post-processing capabilities. Primarily, allows user to specify Coulombic Efficiency to be used for integration.