Dropout (Channel) on HIP and HOST #634
Open
+907
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
r-abishek
commented
Nov 4, 2025
r-abishek
commented
- Adds Channel Dropout augmentation on HIP and HOST
- Adds support for U8/F32/F16/I8 bit depths and NCHW/NHWC variants with toggle support
- Adds relevant unit / qa / performance tests
…all the bitdepths
indentation modified
… as constant for better understanding, added required comments
…d the HOST backend double free fault
…ocs/sphinx (ROCm#632) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.26.0 to 1.27.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.27.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
RPP Dropout : Channel Dropout
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for a new channel dropout augmentation feature to the RPP library. The functionality randomly drops (zeroes out) image channels based on a configurable probability parameter, which is useful for data augmentation in machine learning workflows.
Key Changes:
- Added channel dropout augmentation support for both CPU (HOST) and GPU (HIP) backends
- Implemented support for multiple data types (U8, F16, F32, I8) and layouts (NCHW, NHWC)
- Integrated the new augmentation into the test suite infrastructure
Reviewed Changes
Copilot reviewed 14 out of 17 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| utilities/test_suite/rpp_test_suite_image.h | Added DROPOUT enum value (96), DropoutType enum, and related configuration sets |
| utilities/test_suite/common.py | Added dropout entry to imageAugmentationMap |
| utilities/test_suite/HOST/runImageTests.py | Added dropout test execution logic for unit and performance tests |
| utilities/test_suite/HIP/runImageTests.py | Added dropout test execution logic for unit and performance tests |
| utilities/test_suite/HOST/Tensor_image_host.cpp | Added dropout test case with channel variant support |
| utilities/test_suite/HIP/Tensor_image_hip.cpp | Added dropout test case with channel variant support and memory allocation |
| src/modules/tensor/rppt_tensor_effects_augmentations.cpp | Implemented rppt_channel_dropout_host and rppt_channel_dropout_gpu functions |
| src/modules/tensor/hip/kernel/channel_dropout.cpp | Implemented HIP GPU kernels for channel dropout |
| src/modules/tensor/cpu/kernel/channel_dropout.cpp | Implemented CPU host kernel for channel dropout |
| src/include/tensor/host_tensor_executors.hpp | Added channel_dropout_host_tensor function declaration |
| src/include/tensor/hip_tensor_executors.hpp | Added hip_exec_channel_dropout_tensor function declaration |
| src/include/common/hip/rpp_hip_load_store.hpp | Added FLOAT4_I8_MIN_VALUE constant definition |
| api/rppt_tensor_effects_augmentations.h | Added API documentation for channel dropout functions |
| api/rppdefs.h | Added DROPOUT_FIXED_SEED constant definition |
| docs/data/doxygenOutputs/effects_augmentation_channel_dropout_img150x150.png | Added sample output image for documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Channel Dropout - Copilot review comments Resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #634 +/- ##
===========================================
+ Coverage 88.24% 88.29% +0.05%
===========================================
Files 195 197 +2
Lines 82712 83075 +363
===========================================
+ Hits 72985 73344 +359
- Misses 9727 9731 +4
🚀 New features to boost your workflow:
|
| rpp::Handle &handle) | ||
| { | ||
| if (roiType == RpptRoiType::LTRB) | ||
| hip_exec_roi_converison_ltrb_to_xywh(roiTensorPtrSrc, handle); |
Member
There was a problem hiding this comment.
Please fix the typo in the function name _converison_ -> _conversion_
Contributor
There was a problem hiding this comment.
This issue is prevalent across files. Will issue a common fix PR for the same. Thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.