Repository navigation
test(rccl): add host microtests for net_ib_cast init, capability and GIN #13840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pvallem
merged 22 commits into
develop
from
users/aduforest/aicomrccl-2813-net-ib-cast-init-host-microtests
Oct 25, 2026
+6,672
−36
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0cf7084
test(rccl): add net_ib_cast scheduler, recovery and GDR probe fakes
aduforest f921ea4
test(rccl): place the NET_OPTIONAL_RECV_COMPLETION stub next to rcclU…
aduforest 196c48f
test(rccl): add the shared verbs, socket and net_ib_cast fakes
aduforest 56646bf
test(rccl): add host microtests for net_ib_cast init, capability and GIN
aduforest 4d3155b
test(rccl): address review of the net_ib_cast init microtests
aduforest b0cf375
Merge origin/develop into users/aduforest/aicomrccl-2813-net-ib-cast-…
aduforest f66e1e4
test(rccl): host-only suites declare num_gpus 0
aduforest 5b15c49
test(rccl): skip leaking gin error-path tests under ASan; make the IB…
aduforest a7e2c2e
test(rccl): make the no-verbs init test bite; give merged devices rea…
aduforest 3b4b9ed
Merge remote-tracking branch 'origin/develop' into users/aduforest/ai…
aduforest 022046c
test(rccl): net_ib_cast shared hooks, kAsan header and fewer log chec…
aduforest 79e7fdd
Merge remote-tracking branch 'origin/develop' into users/aduforest/ai…
aduforest 5124b17
test(rccl): net_ib_cast aligned comms, in-range event, no IbCastDevs[…
aduforest 3d9a2d4
Merge remote-tracking branch 'origin/develop' into users/aduforest/ai…
aduforest c0bb04b
test(rccl): fake the ionic uDMA queries and cover the runtime uDMA co…
aduforest 8ef1ac9
Merge remote-tracking branch 'origin/develop' into users/aduforest/ai…
aduforest dbe4f99
test(rccl): address ARGUS findings on net_ib_cast init tests
aduforest 48bcb85
Merge remote-tracking branch 'origin/develop' into users/aduforest/ai…
aduforest 305951a
test(rccl): name the double-free pin's ticket
aduforest e674fbd
Merge remote-tracking branch 'origin/develop' into users/aduforest/ai…
aduforest bba9fe1
test(rccl): set up device 3 so only the range check rejects it per re…
aduforest 62483ad
test(rccl): leave ci-precheckin.json to its code owners
aduforest File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /************************************************************************* | ||
| * Copyright (c) 2026 Advanced Micro Devices, Inc. All rights reserved. | ||
| * | ||
| * See LICENSE.txt for license information | ||
| ************************************************************************/ | ||
|
|
||
| // kAsan is true in an AddressSanitizer build; tests that pin a production leak or overflow skip under it. | ||
| #ifndef RCCL_TEST_HOST_ASANCHECK_H_ | ||
| #define RCCL_TEST_HOST_ASANCHECK_H_ | ||
|
|
||
| #if defined(__SANITIZE_ADDRESS__) | ||
| #define RCCL_TEST_ASAN 1 | ||
| #elif defined(__has_feature) | ||
| #if __has_feature(address_sanitizer) | ||
| #define RCCL_TEST_ASAN 1 | ||
| #endif | ||
| #endif | ||
| #ifndef RCCL_TEST_ASAN | ||
| #define RCCL_TEST_ASAN 0 | ||
| #endif | ||
|
|
||
| constexpr bool kAsan = RCCL_TEST_ASAN; | ||
|
|
||
| #endif // RCCL_TEST_HOST_ASANCHECK_H_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /************************************************************************* | ||
| * Copyright (c) 2026 Advanced Micro Devices, Inc. All rights reserved. | ||
| * | ||
| * See LICENSE.txt for license information | ||
| ************************************************************************/ | ||
|
|
||
| // Implementation of the src/misc/gdr_peermem.cc fakes. See gdr_peermem_fakes.h. | ||
|
|
||
| #include "gdr_peermem_fakes.h" | ||
|
|
||
| #include "fail_loud.h" | ||
| #include "gdr_peermem.h" | ||
| #include "signature-drift.h" | ||
|
|
||
| static int DefaultNcclIbScanDefaultPeerMemClients() { | ||
| FailLoudUnfaked("gdr_peermem_fakes", "ncclIbScanDefaultPeerMemClients"); | ||
| } | ||
| std::function<int()> g_ncclIbScanDefaultPeerMemClients = DefaultNcclIbScanDefaultPeerMemClients; | ||
|
|
||
| ASSERT_HOOK_MATCHES_PROD(g_ncclIbScanDefaultPeerMemClients, ncclIbScanDefaultPeerMemClients); | ||
|
|
||
| int ncclIbScanDefaultPeerMemClients(void) { return g_ncclIbScanDefaultPeerMemClients(); } | ||
|
|
||
| void ResetGdrPeermemFakes() { g_ncclIbScanDefaultPeerMemClients = DefaultNcclIbScanDefaultPeerMemClients; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /************************************************************************* | ||
| * Copyright (c) 2026 Advanced Micro Devices, Inc. All rights reserved. | ||
| * | ||
| * See LICENSE.txt for license information | ||
| ************************************************************************/ | ||
|
|
||
| // Seam for ncclIbScanDefaultPeerMemClients (src/misc/gdr_peermem.cc), whose real | ||
| // answer depends on the host's /sys. Fails loud by default. | ||
|
|
||
| #ifndef RCCL_TEST_HOST_GDR_PEERMEM_FAKES_H_ | ||
| #define RCCL_TEST_HOST_GDR_PEERMEM_FAKES_H_ | ||
|
|
||
| #include <functional> | ||
|
|
||
| extern std::function<int()> g_ncclIbScanDefaultPeerMemClients; | ||
|
|
||
| void ResetGdrPeermemFakes(); | ||
|
|
||
| #endif // RCCL_TEST_HOST_GDR_PEERMEM_FAKES_H_ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| /************************************************************************* | ||
| * Copyright (c) 2026 Advanced Micro Devices, Inc. All rights reserved. | ||
| * | ||
| * See LICENSE.txt for license information | ||
| ************************************************************************/ | ||
|
|
||
| // Implementation of the src/misc/gdr_probe.cc fakes. See gdr_probe_fakes.h. | ||
|
|
||
| #include "gdr_probe_fakes.h" | ||
|
|
||
| #include "fail_loud.h" | ||
| #include "gdr_peermem.h" | ||
| #include "signature-drift.h" | ||
|
|
||
| static int DefaultNcclIbProbeGdrSupport(struct ibv_context*, int) { | ||
| FailLoudUnfaked("gdr_probe_fakes", "ncclIbProbeGdrSupport"); | ||
| } | ||
| std::function<int(struct ibv_context*, int)> g_ncclIbProbeGdrSupport = DefaultNcclIbProbeGdrSupport; | ||
|
|
||
| ASSERT_HOOK_MATCHES_PROD(g_ncclIbProbeGdrSupport, ncclIbProbeGdrSupport); | ||
|
|
||
| int ncclIbProbeGdrSupport(struct ibv_context* context, int relaxedOrderingEnabled) { | ||
| return g_ncclIbProbeGdrSupport(context, relaxedOrderingEnabled); | ||
| } | ||
|
|
||
| void ResetGdrProbeFakes() { g_ncclIbProbeGdrSupport = DefaultNcclIbProbeGdrSupport; } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /************************************************************************* | ||
| * Copyright (c) 2026 Advanced Micro Devices, Inc. All rights reserved. | ||
| * | ||
| * See LICENSE.txt for license information | ||
| ************************************************************************/ | ||
|
|
||
| // Seam for ncclIbProbeGdrSupport (src/misc/gdr_probe.cc), for binaries that do not | ||
| // compile gdr_probe.cc (rccl-UnitTestsMicro does, so it cannot link this). Fails | ||
| // loud by default. | ||
|
|
||
| #ifndef RCCL_TEST_HOST_GDR_PROBE_FAKES_H_ | ||
| #define RCCL_TEST_HOST_GDR_PROBE_FAKES_H_ | ||
|
|
||
| #include <functional> | ||
|
|
||
| struct ibv_context; | ||
|
|
||
| extern std::function<int(struct ibv_context* /*context*/, int /*relaxedOrderingEnabled*/)> g_ncclIbProbeGdrSupport; | ||
|
|
||
| void ResetGdrProbeFakes(); | ||
|
|
||
| #endif // RCCL_TEST_HOST_GDR_PROBE_FAKES_H_ |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.