Skip to content

ci(rccl): run Anvil plugin unit tests in GIN sbatch #12745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dlamd1dai wants to merge 2 commits into from
Closed

ci(rccl): run Anvil plugin unit tests in GIN sbatch #12745

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd4f46b
ci(rccl): run Anvil plugin unit tests in GIN sbatch
dlamd1dai Sep 29, 2026
65169a6
ci(rccl): bound the Anvil plugin gtest and record its failure
dlamd1dai Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions projects/rccl/tools/ci/lib/gin.sbatch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
# (GIN_ANVIL_UNIT_TESTS=ON) -> rccl.env
# 5. projects/rccl-tests build rccl-tests (DEVICE_API + ROCSHMEM)
# 6. rccl-UnitTestsGinAnvilSdmaFactory SDMA factory gtest (single-node)
# 6b. rccl-UnitTestsGinAnvilPlugin Anvil host plugin gtest (single-node)
# 7. run-gin-ci.sh run the GIN/rocSHMEM tests (non-gating)
#
# Required env (from the workflow via `sbatch --export=ALL,...`):
Expand Down Expand Up @@ -332,6 +333,34 @@ else
echo " SKIP: ${sdma_factory_test} not found (BUILD_TESTS may be off)"
fi

# --- unit test: Anvil host plugin gtest (already built in step 4). ---
# Covers the bind-signals and conn-check cases in the Anvil host plugin gtest.
# Step 4 exits if this binary is missing, so there is no skip path here.
# Wall-clock cap matches fixtures in run-gin-ci.sh so a hang cannot burn the
# 4h sbatch budget before the tests-failed sentinel is written.
echo "==> [6b/7] run Anvil plugin unit tests"
anvil_plugin_test="${RCCL_FIXTURES_BIN_DIR}/rccl-UnitTestsGinAnvilPlugin"
BENCH_TIMEOUT="${BENCH_TIMEOUT:-600s}"
BENCH_KILL_AFTER="${BENCH_KILL_AFTER:-30s}"
_sysdeps_lib=""
for _sp in "${ROCM_PATH}/lib/rocm_sysdeps/lib" "${ROCM_PATH}/core/lib/rocm_sysdeps/lib"; do
[[ -d "${_sp}" ]] && _sysdeps_lib="${_sp}"
done
export LD_LIBRARY_PATH="${RCCL_INSTALL_PREFIX}/lib:${ROCSHMEM_INSTALL_DIR}/lib:${ROCM_PATH}/lib${_sysdeps_lib:+:${_sysdeps_lib}}:${LD_LIBRARY_PATH:-}"
anvil_plugin_rc=0
timeout --kill-after="${BENCH_KILL_AFTER}" "${BENCH_TIMEOUT}" \
"${anvil_plugin_test}" --gtest_output="xml:${logs_dir}/anvil-plugin-test.xml" \

@amd-argus amd-argus Bot Oct 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Medium

This invocation has no wall-clock cap, unlike every other test run in this job: run-gin-ci.sh:255 wraps each fixtures run in timeout with BENCH_TIMEOUT (600s by default). Because this runs before step 7, a wedged run consumes the 4h --time budget at line 7 and slurm kills the job, so lines 361-367 never write tests-failed and the hang reads as an infra failure instead of a test timeout. Could we wrap it the same way?

|| anvil_plugin_rc=$?
anvil_plugin_fail=""
if [[ "${anvil_plugin_rc}" -ne 0 ]]; then
if [[ "${anvil_plugin_rc}" -eq 124 || "${anvil_plugin_rc}" -eq 137 ]]; then
anvil_plugin_fail="rccl-UnitTestsGinAnvilPlugin (TIMEOUT >${BENCH_TIMEOUT}, rc=${anvil_plugin_rc})"
else
anvil_plugin_fail="rccl-UnitTestsGinAnvilPlugin (rc=${anvil_plugin_rc})"
fi
echo "WARNING: Anvil plugin unit tests failed (non-gating): ${anvil_plugin_fail}" >&2
fi

# --- test phase -> test-%j.{out,err}. Don't fail the sbatch on test failures
# (that would look like a build/infra failure); drop a `tests-failed` sentinel
# instead, which the workflow turns into a red (non-gating for gin) result. ---
Expand All @@ -349,3 +378,13 @@ if [[ "${test_rc}" -ne 0 ]]; then
[[ -s "${logs_dir}/tests-failed" ]] \
|| echo "GIN tests failed (rc=${test_rc}); see the test log group." > "${logs_dir}/tests-failed"
fi
# Step 6b runs before this redirect, so its failure is not in test-%j.out.
# Append it after step 7's summary, which would otherwise replace the file.
if [[ -n "${anvil_plugin_fail}" ]]; then
if [[ -s "${logs_dir}/tests-failed" ]]; then
printf ' %s\n' "${anvil_plugin_fail}" >> "${logs_dir}/tests-failed"
else
printf '=== FAILED / SKIPPED RUNS ===\n %s\n' "${anvil_plugin_fail}" \
> "${logs_dir}/tests-failed"
fi
fi
Loading