Repository navigation
test(ci): exercise the host-ASAN presubmit against TheRock#8455 #12538
+148
−21
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| # Copyright (c) Advanced Micro Devices, Inc., or its affiliates. | ||
| # | ||
| # SPDX-License-Identifier: MIT | ||
|
|
||
| # Post-build check invoked as: | ||
| # cmake -DFILE=<shared object> -P check_asan_instrumentation.cmake | ||
| # A link-only -fsanitize=address DSO has weak __asan_report_* symbols and no | ||
| # __asan_init. Instrumented objects reference __asan_init. | ||
|
|
||
| if(NOT FILE) | ||
| message(FATAL_ERROR "FILE must be the shared object to check") | ||
| endif() | ||
|
|
||
| find_program(NM_TOOL NAMES nm llvm-nm REQUIRED) | ||
| execute_process( | ||
| COMMAND ${NM_TOOL} -D ${FILE} | ||
| RESULT_VARIABLE _nm_rc | ||
| OUTPUT_VARIABLE _nm_out | ||
| ERROR_VARIABLE _nm_err) | ||
| if(NOT _nm_rc EQUAL 0) | ||
| message(FATAL_ERROR "nm -D ${FILE} failed (${_nm_rc}): ${_nm_err}") | ||
| endif() | ||
| # __asan_init is emitted only when at least one object was instrumented. | ||
| # Do not anchor this to whitespace: CMake's regex engine does not treat a | ||
| # newline after the symbol as a line boundary for `$`, which made a genuine | ||
| # `U __asan_init` false-negative after llvm-strip. | ||
| if(NOT _nm_out MATCHES "__asan_init") | ||
| set(_asan_lines "") | ||
| string(REPLACE "\n" ";" _nm_lines "${_nm_out}") | ||
| foreach(_line IN LISTS _nm_lines) | ||
| if(_line MATCHES "asan") | ||
| string(APPEND _asan_lines "\n ${_line}") | ||
| endif() | ||
| endforeach() | ||
| if(_asan_lines STREQUAL "") | ||
| set(_asan_lines "\n (no asan symbols in the dynamic table)") | ||
| endif() | ||
| message(FATAL_ERROR | ||
| "${FILE} is not instrumented with ASan (dynamic symbol __asan_init is missing). " | ||
| "The library was linked with the ASan runtime but its objects were not compiled " | ||
| "with -fsanitize=address. Dynamic asan symbols:${_asan_lines}") | ||
| endif() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64,3 +64,5 @@ char* GetEnv(const char* env_var_name) { | |
| } | ||
|
|
||
| } // namespace rocrtst | ||
|
|
||
| // Touched to force a CI build for host-ASAN validation (TheRock#8455). Revert before merge. | ||
|
Contributor
There was a problem hiding this comment. 🤖 AI-assisted pre-review (for @cfreeamd) [Required] This comment-touch must be reverted before merge (as the comment itself notes). No functional change — just a CI trigger artifact. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤖 AI-assisted pre-review (for @cfreeamd)
[Required] This pins to a mutable branch ref (
users/dravindr/host_asan_8455_test) rather than a commit SHA. The original lines usedc01e3a3f3f67966dd35612cf363b49964f33cd47— branch refs can be force-pushed, silently changing what the CI runs. All threeref:occurrences here must be replaced with a pinned SHA before merge.