Repository navigation
Conversation
github-actions
Bot
added
the
github actions
✅ All Policy Checks Passed
📖 Need help? See the Policy FAQ for details on every check and how to fix failures. |
5 tasks done
raramakr
force-pushed
the
users/raramakr/host-asan
branch
2 times, most recently
from
August 31, 2026 18:37
e90ea6d to
507211c
Compare
This was referenced Aug 31, 2026
ScottTodd
reviewed
Aug 31, 2026
ScottTodd
left a comment
ScottTodd
left a comment
Member
There was a problem hiding this comment.
The code changes here look okay, but let's stick the landing for the standard (non-asan) multi-arch CI in this repository before we also enable asan (which uses significantly more resources).
geomin12
reviewed
Sep 1, 2026
geomin12
left a comment
geomin12
left a comment
Contributor
There was a problem hiding this comment.
error in startup:
[Invalid workflow file: .github/workflows/therock-multi-arch-ci-asan.yml#L63](https://github.com/ROCm/rocm-systems/actions/runs/33427588280/workflow)
The workflow is not valid. .github/workflows/therock-multi-arch-ci-asan.yml (Line: 63, Col: 21): Invalid input, build_stages is not defined in the referenced workflow.
https://github.com/ROCm/rocm-systems/actions/runs/33427588280
added 2 commits
September 1, 2026 11:14
Configure therock-multi-arch-ci-asan.yml to use TheRock's focused presubmit inputs (TheRock#7311): - build_stages: compiler-runtime,runtime-tests (skip math-libs, etc.) - asan_presubmit: true (run on every PR without ci:asan label) - lock_test_labels: true (PR labels cannot widen test scope) - sanity_blocks_components: false (sanity failures don't block tests) - linux_test_labels: test:hip-tests,test:rocrtst - Disable build_native_linux, build_python_packages, build_pytorch, build_jax - validate_artifact_structure: false (partial builds skip validation) This enables automatic host-ASAN testing on every PR with minimal build cost, catching host-side memory errors in runtime components.
Switch to host-asan build variant which enables automatic test
execution for external repos with build_stages set. This removes
the need for ci:asan or ci:host-asan labels on PRs.
Changes:
- Use build_variant: "host-asan" instead of "asan"
- Remove non-existent inputs (asan_presubmit, lock_test_labels,
sanity_blocks_components, validate_artifact_structure)
- Update comments to reflect actual behavior
The presubmit is scoped to compiler-runtime and runtime-tests stages,
running hip-tests and rocrtst on every PR automatically.
raramakr
force-pushed
the
users/raramakr/host-asan
branch
from
September 1, 2026 18:14
904c83d to
84b794f
Compare
Contributor
Author
The initial commit reference didn't had the changes for build_stages. |
geomin12
reviewed
Sep 3, 2026
Comment on lines
+70
to
+73
| build_native_linux: false | ||
| build_python_packages: false | ||
| build_pytorch: false | ||
| build_jax: false |
Contributor
There was a problem hiding this comment.
oh i added these! pls rebase
Resolves a conflict with #11233, which disabled Python/PyTorch/JAX for the ASAN workflow while this branch was doing the same as part of scoping the host-ASAN presubmit. Both sides set the same three inputs, so develop's copy and its rationale comment are kept and this branch's duplicates dropped; taking both would have produced duplicate YAML keys. Co-authored-by: Cursor <cursoragent@cursor.com>
dileepr1
added a commit
that referenced
this pull request
Sep 8, 2026
Resolves the same #11233 conflict as #10558: develop disabled Python/PyTorch/JAX for the ASAN workflow while this branch was already doing so as part of scoping the host-ASAN presubmit. Keeps develop's rationale comment and this branch's single copy of the three inputs, since taking both sides would produce duplicate YAML keys. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task done
geomin12
approved these changes
Oct 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configure therock-multi-arch-ci-asan.yml for automatic host-ASAN
presubmit testing on every rocm-systems PR.
PRs automatically trigger host-ASAN builds and tests without
requiring ci:asan or ci:host-asan labels.
Satisfies ROCm/TheRock#7202
ISSUE ID: ROCm/TheRock#7202