Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement gesdd #899

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from
+3,089 −4
Open

Implement gesdd #899

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
8963eea
Add necessary files for gesdd, stub implementation
jmachado-amd Feb 13, 2025
ec890ef
Minimal working implementation
jmachado-amd Feb 14, 2025
f68d422
Tidy-up sources
jmachado-amd Feb 19, 2025
1c16d43
Small changes
jmachado-amd Feb 21, 2025
c33d0f3
Update tests
jmachado-amd Feb 25, 2025
4e9d288
Update main `gesdd` method
jmachado-amd Feb 25, 2025
0612272
Merge remote-tracking branch 'origin/develop' into implement-minimal-…
jmachado-amd Feb 25, 2025
67bf799
Update error bounds of orthogonality tests
jmachado-amd Feb 26, 2025
197b844
Update test tolerance
jmachado-amd Feb 26, 2025
61b9a44
Update gesdd_getMemorySize method
jmachado-amd Mar 5, 2025
8876006
Update changelog and code comments
jmachado-amd Mar 5, 2025
53f3558
Implement review comment
jmachado-amd Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions clients/common/lapack/testing_gesdd.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,14 +87,14 @@ void gesdd_checkBadArgs(const rocblas_handle handle,
(T) nullptr, lda, stA, abstol, dResidual, max_sweeps,
dSweeps, dS, stS, dU, ldu, stU, dV, ldv, stV, dinfo, bc),
rocblas_status_invalid_pointer);
EXPECT_ROCBLAS_STATUS(rocsolver_gesdd(STRIDED, handle, left_svect, right_svect, m, n, dA, lda,
stA, abstol, (S) nullptr, max_sweeps, dSweeps, dS, stS,
dU, ldu, stU, dV, ldv, stV, dinfo, bc),
rocblas_status_invalid_pointer);
EXPECT_ROCBLAS_STATUS(rocsolver_gesdd(STRIDED, handle, left_svect, right_svect, m, n, dA, lda,
stA, abstol, dResidual, max_sweeps, (I) nullptr, dS, stS,
dU, ldu, stU, dV, ldv, stV, dinfo, bc),
rocblas_status_invalid_pointer);
/* EXPECT_ROCBLAS_STATUS(rocsolver_gesdd(STRIDED, handle, left_svect, right_svect, m, n, dA, lda, */
/* stA, abstol, (S) nullptr, max_sweeps, dSweeps, dS, stS, */
/* dU, ldu, stU, dV, ldv, stV, dinfo, bc), */
/* rocblas_status_invalid_pointer); */
/* EXPECT_ROCBLAS_STATUS(rocsolver_gesdd(STRIDED, handle, left_svect, right_svect, m, n, dA, lda, */
/* stA, abstol, dResidual, max_sweeps, (I) nullptr, dS, stS, */
/* dU, ldu, stU, dV, ldv, stV, dinfo, bc), */
/* rocblas_status_invalid_pointer); */
EXPECT_ROCBLAS_STATUS(rocsolver_gesdd(STRIDED, handle, left_svect, right_svect, m, n, dA, lda,
stA, abstol, dResidual, max_sweeps, dSweeps, (S) nullptr,
stS, dU, ldu, stU, dV, ldv, stV, dinfo, bc),
Expand Down Expand Up @@ -847,9 +847,9 @@ void testing_gesdd(Arguments& argus)
// using 2 * min(m, n) * machine_precision as tolerance
if(argus.unit_check)
{
ROCSOLVER_TEST_CHECK(T, max_error, 2 * std::min(m, n));
ROCSOLVER_TEST_CHECK(T, max_error, 2 * 20 * std::min(m, n));
if(svects)
ROCSOLVER_TEST_CHECK(T, max_errorv, 2 * std::min(m, n));
ROCSOLVER_TEST_CHECK(T, max_errorv, 2 * 20 * std::min(m, n));
}

// output results for rocsolver-bench
Expand Down
46 changes: 25 additions & 21 deletions clients/common/misc/rocsolver.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4197,10 +4197,12 @@ inline rocblas_status rocsolver_gesdd(bool STRIDED,
rocblas_int bc)
{
return STRIDED ? rocsolver_sgesdd_strided_batched(handle, leftv, rightv, m, n, A, lda, stA,
abstol, residual, max_sweeps, n_sweeps, S,
stS, U, ldu, stU, V, ldv, stV, info, bc)
: rocsolver_sgesdd(handle, leftv, rightv, m, n, A, lda, abstol, residual,
max_sweeps, n_sweeps, S, U, ldu, V, ldv, info);
// abstol, residual, max_sweeps, n_sweeps,
S, stS, U, ldu, stU, V, ldv, stV, info, bc)
: rocsolver_sgesdd(handle, leftv, rightv, m, n, A, lda,
// abstol, residual,
// max_sweeps, n_sweeps,
S, U, ldu, V, ldv, info);
}

inline rocblas_status rocsolver_gesdd(bool STRIDED,
Expand Down Expand Up @@ -4228,10 +4230,12 @@ inline rocblas_status rocsolver_gesdd(bool STRIDED,
rocblas_int bc)
{
return STRIDED ? rocsolver_dgesdd_strided_batched(handle, leftv, rightv, m, n, A, lda, stA,
abstol, residual, max_sweeps, n_sweeps, S,
// abstol, residual, max_sweeps, n_sweeps,
S,
stS, U, ldu, stU, V, ldv, stV, info, bc)
: rocsolver_dgesdd(handle, leftv, rightv, m, n, A, lda, abstol, residual,
max_sweeps, n_sweeps, S, U, ldu, V, ldv, info);
: rocsolver_dgesdd(handle, leftv, rightv, m, n, A, lda, // abstol, residual,
/* max_sweeps, n_sweeps, */
S, U, ldu, V, ldv, info);
}

inline rocblas_status rocsolver_gesdd(bool STRIDED,
Expand Down Expand Up @@ -4259,10 +4263,10 @@ inline rocblas_status rocsolver_gesdd(bool STRIDED,
rocblas_int bc)
{
return STRIDED ? rocsolver_cgesdd_strided_batched(handle, leftv, rightv, m, n, A, lda, stA,
abstol, residual, max_sweeps, n_sweeps, S,
/* abstol, residual, max_sweeps, n_sweeps,*/ S,
stS, U, ldu, stU, V, ldv, stV, info, bc)
: rocsolver_cgesdd(handle, leftv, rightv, m, n, A, lda, abstol, residual,
max_sweeps, n_sweeps, S, U, ldu, V, ldv, info);
: rocsolver_cgesdd(handle, leftv, rightv, m, n, A, lda, /*abstol, residual,
max_sweeps, n_sweeps,*/ S, U, ldu, V, ldv, info);
}

inline rocblas_status rocsolver_gesdd(bool STRIDED,
Expand Down Expand Up @@ -4290,10 +4294,10 @@ inline rocblas_status rocsolver_gesdd(bool STRIDED,
rocblas_int bc)
{
return STRIDED ? rocsolver_zgesdd_strided_batched(handle, leftv, rightv, m, n, A, lda, stA,
abstol, residual, max_sweeps, n_sweeps, S,
/* abstol, residual, max_sweeps, n_sweeps,*/ S,
stS, U, ldu, stU, V, ldv, stV, info, bc)
: rocsolver_zgesdd(handle, leftv, rightv, m, n, A, lda, abstol, residual,
max_sweeps, n_sweeps, S, U, ldu, V, ldv, info);
: rocsolver_zgesdd(handle, leftv, rightv, m, n, A, lda, /* abstol, residual,
max_sweeps, n_sweeps,*/ S, U, ldu, V, ldv, info);
}

// batched
Expand Down Expand Up @@ -4321,8 +4325,8 @@ inline rocblas_status rocsolver_gesdd(bool STRIDED,
rocblas_int* info,
rocblas_int bc)
{
return rocsolver_sgesdd_batched(handle, leftv, rightv, m, n, A, lda, abstol, residual,
max_sweeps, n_sweeps, S, stS, U, ldu, stU, V, ldv, stV, info,
return rocsolver_sgesdd_batched(handle, leftv, rightv, m, n, A, lda, /* abstol, residual,
max_sweeps, n_sweeps,*/ S, stS, U, ldu, stU, V, ldv, stV, info,
bc);
}

Expand Down Expand Up @@ -4350,8 +4354,8 @@ inline rocblas_status rocsolver_gesdd(bool STRIDED,
rocblas_int* info,
rocblas_int bc)
{
return rocsolver_dgesdd_batched(handle, leftv, rightv, m, n, A, lda, abstol, residual,
max_sweeps, n_sweeps, S, stS, U, ldu, stU, V, ldv, stV, info,
return rocsolver_dgesdd_batched(handle, leftv, rightv, m, n, A, lda, /*abstol, residual,
max_sweeps, n_sweeps,*/ S, stS, U, ldu, stU, V, ldv, stV, info,
bc);
}

Expand Down Expand Up @@ -4379,8 +4383,8 @@ inline rocblas_status rocsolver_gesdd(bool STRIDED,
rocblas_int* info,
rocblas_int bc)
{
return rocsolver_cgesdd_batched(handle, leftv, rightv, m, n, A, lda, abstol, residual,
max_sweeps, n_sweeps, S, stS, U, ldu, stU, V, ldv, stV, info,
return rocsolver_cgesdd_batched(handle, leftv, rightv, m, n, A, lda, /* abstol, residual,
max_sweeps, n_sweeps,*/ S, stS, U, ldu, stU, V, ldv, stV, info,
bc);
}

Expand Down Expand Up @@ -4408,8 +4412,8 @@ inline rocblas_status rocsolver_gesdd(bool STRIDED,
rocblas_int* info,
rocblas_int bc)
{
return rocsolver_zgesdd_batched(handle, leftv, rightv, m, n, A, lda, abstol, residual,
max_sweeps, n_sweeps, S, stS, U, ldu, stU, V, ldv, stV, info,
return rocsolver_zgesdd_batched(handle, leftv, rightv, m, n, A, lda, /* abstol, residual,
max_sweeps, n_sweeps,*/ S, stS, U, ldu, stU, V, ldv, stV, info,
bc);
}
/********************************************************/
Expand Down
Loading