Use new LASR in STEQR and BDSQR and parallelize STEQR #897
+328
−369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfalders
requested review from
jzuniga-amd,
cgmb,
qjojo,
EdDAzevedo,
jmachado-amd and
AGonzales-amd
as code owners
tfalders
added
the
noOptimizations
|
Looks good. Adding a comment below to trigger the performance tracking system (PTS) so that we can verify performance improvements. |
|
%PTS |
EdDAzevedo
approved these changes
Feb 21, 2025
tfalders
changed the title
EdDAzevedo
approved these changes
Mar 4, 2025
jzuniga-amd
reviewed
Mar 6, 2025
| { | ||
| D[end] *= scale; | ||
| for(int i = start; i < end; i++) | ||
| for(int i = tid; i < end; i += tid_inc) |
There was a problem hiding this comment.
and how is start taken into consideration now?
The old code scales elements in [start, end]
This new multithreaded code scales elements in [first_tid, end]... what if the first thread index is not equal to start?
| if(anorm == 0) | ||
| continue; | ||
| else if(anorm > ssfmax) | ||
| scale_tridiag(l, lend, D, E, anorm / ssfmax); | ||
| scale_tridiag(lsv, lendsv, D, E, anorm / ssfmax, tid, tid_inc); |
There was a problem hiding this comment.
these scale_tridiag calls are being done by all threads (from tid=0 to tid=63) to scale elements in [lsv, lendsv]
I don't understand what happened when lsv != 0 ?
(See the comments about scale_tridiag above)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.