Skip to content

Compute Top Kernels#698

Open
drchen-amd wants to merge 2 commits intodevfrom
amd/dev/drchen/summary
Open

Compute Top Kernels#698
drchen-amd wants to merge 2 commits intodevfrom
amd/dev/drchen/summary

Conversation

@drchen-amd
Copy link
Contributor

@drchen-amd drchen-amd commented Feb 27, 2026

TimelineView

  • Factored out grid/histogram ruler interval calculation into FittedGraphAxisInterval() in rocprofvis_utils.cpp. The top kernels bar chart makes use of it.

ComputeDataModel

  • Moved Kernel invocation count and duration metrics into array for more convenient access.

ComputeSummaryView

  • Added ComputeTopKernels widget

Roofline

  • Reworked the conditions for "No Data Available" screen. Widget will always render its frame regardless of ComputeSelection. This was a small change but resulted in a large diff in rocprofvis_compute_roofline.cpp as {} where moved around.
  • Reworked the logic for differentiating between "single kernel" and "all kernels" modes. Instead of being implicit based on SetKernel(), it is now explicitly set on creation. This removes the previous behavior of re-build the workload metadata when only the kernel selection changes.
  • Corrected typo Inovcation(s) in kernel tooltip.
  • Added missing unit for Duration in kernel tooltip.

SummaryView

  • Fixed bar chart hover region being wider than bar width.

@drchen-amd drchen-amd force-pushed the amd/dev/drchen/summary branch 4 times, most recently from 8c1f4e0 to 5f976d8 Compare February 27, 2026 01:36
@drchen-amd drchen-amd changed the title Compute Summary Compute Top Kernels Feb 27, 2026
@drchen-amd drchen-amd marked this pull request as ready for review February 27, 2026 02:06
Copy link
Collaborator

@tomk-amd tomk-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can table columns be sorted? Clicking on the headers does not initiate a sort?

@drchen-amd drchen-amd marked this pull request as draft February 27, 2026 18:09
-Compute Summary
@drchen-amd drchen-amd force-pushed the amd/dev/drchen/summary branch from 5f976d8 to 099b9f1 Compare February 27, 2026 23:41
@drchen-amd
Copy link
Contributor Author

Can table columns be sorted? Clicking on the headers does not initiate a sort?

I was not planning to have any sorting besides the static top 10 by duration since any sorting would be done temporarily by the view. I can do it anyway if you believe it worth it.

@drchen-amd drchen-amd marked this pull request as ready for review February 27, 2026 23:47
@drchen-amd drchen-amd requested a review from tomk-amd February 27, 2026 23:48
-Fix up to 11 kernels being shown instead of 10.
-Fix inverted axis label dirty flag.
-Add y axis labels.
-Remove "Others" bar for metrics that do not have data for it.
@drchen-amd drchen-amd force-pushed the amd/dev/drchen/summary branch from 099b9f1 to 827cb45 Compare February 28, 2026 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants