Open
Conversation
8c1f4e0 to
5f976d8
Compare
tomk-amd
requested changes
Feb 27, 2026
Collaborator
tomk-amd
left a comment
There was a problem hiding this comment.
Can table columns be sorted? Clicking on the headers does not initiate a sort?
tomk-amd
requested changes
Feb 27, 2026
-Compute Summary
5f976d8 to
099b9f1
Compare
Contributor
Author
I was not planning to have any sorting besides the static top 10 by duration since any sorting would be done temporarily by the view. I can do it anyway if you believe it worth it. |
-Fix up to 11 kernels being shown instead of 10. -Fix inverted axis label dirty flag. -Add y axis labels. -Remove "Others" bar for metrics that do not have data for it.
099b9f1 to
827cb45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TimelineViewFittedGraphAxisInterval()inrocprofvis_utils.cpp. The top kernels bar chart makes use of it.ComputeDataModelComputeSummaryViewComputeTopKernelswidgetRooflineComputeSelection. This was a small change but resulted in a large diff inrocprofvis_compute_roofline.cppas{}where moved around.Inovcation(s)in kernel tooltip.Durationin kernel tooltip.SummaryView