Conversation
Added additional utility functions to ComputeDataModel class. Table data ready callback now passes back response code as well. Moved compute tester implementation to its own file. Added callback functions to query builder.
tomk-amd
requested review from
a team,
Sajeeth-Wimalasuriyan,
amokiche-amd,
drchen-amd and
vstempen
as code owners
… can't use the same backing model as they clobber each others state.
Added assert.
drchen-amd
approved these changes
Feb 27, 2026
Contributor
drchen-amd
left a comment
drchen-amd
left a comment
There was a problem hiding this comment.
I think it is confusing that this selection table is on the same page as the memory chart and roofline because the selection table ignores the kernel selection while memory chart and roofline respect it.
src/view/src/compute/rocprofvis_compute_kernel_metric_table.cpp
Outdated
Show resolved
Hide resolved
Collaborator
Author
The Selection table is what the user uses to select the kernel that affects the items below. The layout for this page will be re-worked as well once all the components are in. The flexbox PR will help with this too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add a kernel selection table.
Table allows user to add / remove custom metric value columns.
The active kernel can be selected using this table.
Also added support for running metric fetches in parallel. (This fixes issue where the table view does not update correctly when switching kernels because fetch request gets blocked by another client).
Technical Details
Metrics are selected using the query builder helper object.
Kernel selection is synchronized with toolbar kernel selection combo box.
Additional utility functions added to ComputeDataModel.
Compute tester moved to its own implementation files.