Skip to content

Legend Position Manual Adjust #692

Open
Sajeeth-Wimalasuriyan wants to merge 1 commit intodevfrom
swimalas/Legend_move
Open

Legend Position Manual Adjust #692
Sajeeth-Wimalasuriyan wants to merge 1 commit intodevfrom
swimalas/Legend_move

Conversation

@Sajeeth-Wimalasuriyan
Copy link
Contributor

No description provided.

…-move icon) to the roofline chart that cycles the legend panel through all four corners (top-right, top-left, bottom-left, bottom-right), with positioning that respects the plot area boundaries so it doesn't cover axis labels.
Copy link
Contributor

@drchen-amd drchen-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be nice if the menus did not block so much of chart, but moving it around does not solve the problem. It just blocks different areas.

I was planning to have an inside/outside toggle originally but dropped it for time:

Image

Iinstead of moving the menus, the chart switches between fully spanning and partial spanning. I think the benefit of this over moving stuff around is that...

  1. In the outside mode, the chart is not blocked period.
  2. Code is simpler. Only the widths of the widgets change, which is simple to do. You don't need any of the positioning math.

The toggle to enable inside/outside would go in the option settings in the gear menu (where the scaled kernel sizes is). It could be a checkbox or button that cycles between inside/outside.

@drchen-amd
Copy link
Contributor

Talked with Sajeeth offline. The inside/outside can be a stretch goal. We will proceed with current approach but with some further tweaks:

  • The move button should be in the gear menu where kernel size option is.
  • The misalignment of the hide and gear buttons when menus is on the left side should be fixed.
  • The hide and gear buttons should be anchored to the bottom when menus is on the bottom (without overlapping the mouse coordinate display). Their order should also be inverted such that gear is above the hide when menus is on the bottom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants