Draft
Conversation
… copy support to the compute table view.
Sajeeth-Wimalasuriyan
requested review from
a team,
amokiche-amd,
drchen-amd,
tomk-amd and
vstempen
as code owners
tomk-amd
reviewed
Feb 24, 2026
Comment on lines
+262
to
+264
| std::string metric_id = std::to_string(cat.id) + "." + | ||
| std::to_string(tbl_id) + "." + | ||
| std::to_string(eid); |
Collaborator
There was a problem hiding this comment.
Would be better to not have to do this concatenation every frame
Comment on lines
+288
to
+289
| char buf[64]; | ||
| snprintf(buf, sizeof(buf), "%.2f", mv->values.begin()->second); |
Collaborator
There was a problem hiding this comment.
can we avoid memcopy every frame?
Collaborator
|
Changing this to a draft. It will need to be reworked or ported after Table Widget PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added metric ID column, description tooltip on hover, and right-click copy support to the compute table view.