Open
Conversation
…(code simplifications).
Sajeeth-Wimalasuriyan
requested review from
amokiche-amd,
drchen-amd and
tomk-amd
as code owners
tomk-amd
requested changes
Feb 21, 2026
Collaborator
tomk-amd
left a comment
tomk-amd
left a comment
There was a problem hiding this comment.
Would be nice if this also highlighted an event the is "jumped to" using the context menu in the event table. But I'm not sure what would be a consitent way of clearing the highlight in scenario should be?
Comment on lines
+703
to
+712
| ImVec2 container_pos = ImGui::GetWindowPos(); | ||
| double normalized_start = | ||
| container_pos.x + m_tpt->RawTimeToPixel(item.event.m_start_ts); | ||
|
|
||
| double normalized_duration = | ||
| std::max(item.event.m_duration * m_tpt->GetPixelsPerNs(), 1.0); | ||
|
|
||
| ImVec2 start_position; | ||
| float rounding = 2.0f; | ||
| start_position = ImVec2(static_cast<float>(normalized_start), |
Collaborator
There was a problem hiding this comment.
Extract rendering logic into a RenderBoxFrame(frame_color) method and use for both selection and highlight
tomk-amd
reviewed
Feb 21, 2026
Comment on lines
+214
to
+216
| m_search_highlighted_event_ids.insert(event_id); | ||
| SendEventSelectionChanged(event_id, track_id, true); | ||
| } |
Collaborator
There was a problem hiding this comment.
Highlight needs it own event(s). It should not piggy back off of event selection events. As is highlighting an event will clear / alter selection
| { | ||
| item.selected = m_timeline_selection->EventSelected(item.event.m_id.uuid); | ||
| item.search_highlighted = m_timeline_selection->EventSearchHighlighted(item.event.m_id.uuid); | ||
| } |
Collaborator
There was a problem hiding this comment.
Search highlight state should be handled in a dedicated event
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.