[MLIR][OpenMP] Fix failing Lit tests #242
Merged
+16
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The omptarget-threadprivate-device-lowering.mlir test is updated with a valid target triple to prevent triggering an assertion during translation to LLVM IR. The openmp-todo.mlir test is updated, since unsupported simd clauses no longer trigger errors but rather warnings. Messages triggered by these are also updated to avoid misleading users.
ergawy
approved these changes
Jan 13, 2025
| @@ -525,7 +526,8 @@ static llvm::omp::ProcBindKind getProcBindKind(omp::ClauseProcBindKind kind) { | |||
| /// been mapped to LLVM IR values. | |||
| static LogicalResult | |||
| convertIgnoredWrapper(omp::LoopWrapperInterface opInst, | |||
| LLVM::ModuleTranslation &moduleTranslation) { | |||
| LLVM::ModuleTranslation &moduleTranslation, | |||
| const char *warningFmt) { | |||
There was a problem hiding this comment.
Can we do these changes upstream directly?
There was a problem hiding this comment.
At the moment at least, I don't think people upstream would be happy replacing errors with warnings when translating unsupported simd clauses. And there's not a need for adding a format string here unless we want to do something like that, so in my opinion this needs to remain downstream-only until simd clauses are all supported, at which point we could revert these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The omptarget-threadprivate-device-lowering.mlir test is updated with a valid target triple to prevent triggering an assertion during translation to LLVM IR.
The openmp-todo.mlir test is updated, since unsupported simd clauses no longer trigger errors but rather warnings. Messages triggered by these are also updated to avoid misleading users.