Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when inode file ID cannot be created #227

Open
wants to merge 1 commit into
base: amd-trunk-dev
Choose a base branch
from

Conversation

mjklemm
Copy link

@mjklemm mjklemm commented Dec 9, 2024

This PR fixes a problem when the file ID cannot be determined during code-gen to create a unique symbol name. This can happen when a preprocessor leaves a file name in the line tag that does not exist.

@mjklemm mjklemm added the flang label Dec 9, 2024
@mjklemm mjklemm self-assigned this Dec 9, 2024
This PR fixes a problem when the the file ID cannot be determined during code-gen to create a unique symbol name.  This can happen when a preprocessor leaves a file name in the line tag that does not exist.
@mjklemm mjklemm force-pushed the fix-missing-inode-id branch from 874778a to 7f75c76 Compare December 9, 2024 19:57
@mjklemm mjklemm changed the title Fix issue when inode file ID cannot be created. Fix issue when inode file ID cannot be created Dec 9, 2024
Copy link

@skatrak skatrak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Michael, this looks good to me. I think we should add a unit test for it, though. Passing the input MLIR through stdin to mlir-translate should trigger this (e.g. cat test.mlir | mlir-translate -mlir-to-llvmir - | FileCheck test.mlir).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants