Repository navigation
Add a section to AGENTS.md about code review - #272
Merged
Merged
Conversation
Ask agents to review their whole change before handing it back, with a checklist drawn from what Copilot has asked for on past hipObject PRs: changelog entries, missing files, incomplete fixes, tests that pass without the fix, cleanup and exception paths, strict parsing, script failure handling, the rules in AGENTS.md, and accurate wording. Co-Authored-By: Claude <noreply@anthropic.com>
derobins
requested review from
akolliasAMD,
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon,
sbates130272 and
zbyrne
as code owners
October 21, 2026 17:32
Contributor
Security scan found no critical or high findings on lines changed by this pull requestView the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The documentation-only change matches its stated purpose and has no identified blocking issues.
No open issues 🎉
What changed in this PR
Adds self-review guidance to hipObject’s agent instructions, based on recurring feedback from past PRs.
Changes:
- Requires reviewing the whole change and rerunning checks before handoff.
- Adds a checklist covering completeness, regression tests, cleanup, parsing, script failures, and documentation accuracy.
| File | Description |
|---|---|
| AGENTS.md | Adds the pre-handoff review requirement and checklist. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ask agents to review their whole change before handing it back, with a checklist drawn from what Copilot has asked for on past hipObject PRs: changelog entries, missing files, incomplete fixes, tests that pass without the fix, cleanup and exception paths, strict parsing, script failure handling, the rules in AGENTS.md, and accurate wording.