Repository navigation
Document what the Ansible client play does to a host - #270
Merged
Merged
Conversation
The client play's two roles come from sbates130272.batesste, a personal Ansible Galaxy collection. ansible/README.md now says so and describes what the roles change on a client with hipObject's settings: an apt upgrade, a third-party PPA for rdmatop on Ubuntu 24.04, ROCm and amdgpu-dkms installs, and removal of any ROCm installed from repo.radeon.com. The README also: - Gives the minimum as ansible-core 2.18, which community.general 13.4 needs, instead of Ansible 2.14 - Notes that requirements.yml accepts any version of the collection - Documents hipobj_source_dir, hipobj_repo_version, and the RDMA backend variables - Fixes the link to the CI workflow, which is now hipobject-ansible.yml Co-Authored-By: Claude <noreply@anthropic.com>
derobins
requested review from
akolliasAMD,
gaoikawa,
jordan-turbofish,
kurtmcmillan,
riley-dixon,
sbates130272 and
zbyrne
as code owners
October 19, 2026 21:54
Contributor
Security scan found no critical or high findings on lines changed by this pull requestView the security scan run for complete reports. “New” means the finding is located in a changed file on an added or modified line; it is not a base-versus-head findings delta. |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The package-removal description misstates the scope of a destructive provisioning operation.
1 open issue
What changed in this PR
Documents how hipObject’s Ansible client provisioning affects a host, without changing playbook behavior.
Changes:
- Explains the external roles and their system-level changes.
- Updates prerequisites and clarifies collection version selection.
- Documents build variables and corrects the CI workflow link.
| File | Description |
|---|---|
| ansible/README.md | Expands provisioning guidance, prerequisites, and configuration details. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The client play's two roles come from sbates130272.batesste, a personal Ansible Galaxy collection. ansible/README.md now says so and describes what the roles change on a client with hipObject's settings: an apt upgrade, a third-party PPA for rdmatop on Ubuntu 24.04, ROCm and amdgpu-dkms installs, and removal of any ROCm installed from repo.radeon.com.
The README also: