-
Notifications
You must be signed in to change notification settings - Fork 249
[CK-Tile] Add gtests for compiler CI for faster testing #3123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…rnel into enable_gtest_compiler
|
|
||
| TYPED_TEST(TEST_SUITE_NAME, SmallM_CompV3) | ||
| { | ||
| std::vector<int> Ms{1, 2, 3, 4, 5, 6}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks generally good to me. Please decrease the M numbers to only 1 to 2 in that case to decrease the test and build time. Also, the shapes for CompV3 could also been used for V4 and memory pipeline. So it could be used across the pipelines and across the hardware arch.
| CompV4>>; | ||
|
|
||
| // CompV4 Pipeline WMMA Types | ||
| using CompV4WmmaTestTypes = ::testing::Types< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Types should be separates by hardware archs.
|
please consider changing the PR description to non-default one |
Proposed changes
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered