Skip to content

Conversation

@vidyasagar-amd
Copy link
Contributor

@vidyasagar-amd vidyasagar-amd commented Oct 17, 2025

Proposed changes

Making our launch script more robust so that we dont encounter this error:
[2025-10-16T23:37:09.714Z] ../script/launch_tests.sh: line 59: /usr/bin/ctest: Argument list too long`

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

illsilin
illsilin previously approved these changes Oct 28, 2025
@AviralGoelAMD AviralGoelAMD requested a review from Copilot October 29, 2025 15:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the test launch script to run tests in configurable chunks rather than as a single ctest command. The changes enable better control over test execution with support for chunked execution and fail-fast behavior.

Key changes:

  • Replaces the single ctest command generation with a Python script that executes tests in chunks
  • Adds configurable chunk size and fail-fast mode via environment variables
  • Implements test execution tracking with detailed summary reporting

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@vidyasagar-amd vidyasagar-amd force-pushed the fix-argument-list-issue branch from 9706181 to 09cc3a2 Compare October 31, 2025 16:36
@vidyasagar-amd vidyasagar-amd merged commit 31c019f into develop Nov 4, 2025
49 checks passed
@vidyasagar-amd vidyasagar-amd deleted the fix-argument-list-issue branch November 4, 2025 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants