Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grouped conv backward data GKCYX support #2029

Merged
merged 9 commits into from
Apr 1, 2025
Merged

Grouped conv backward data GKCYX support #2029

merged 9 commits into from
Apr 1, 2025

Conversation

bartekxk
Copy link
Contributor

Proposed changes

Grouped conv backward data GKCYX support

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@bartekxk bartekxk self-assigned this Mar 27, 2025
spolifroni-amd
spolifroni-amd requested changes Mar 28, 2025
View reviewed changes
geyyer
geyyer previously approved these changes Mar 31, 2025
View reviewed changes
Copy link
Contributor

@geyyer geyyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Overall looks good, some comments about input/output dimensions.

@illsilin illsilin merged commit 8c0ab61 into develop Apr 1, 2025
33 of 39 checks passed
@bartekxk bartekxk deleted the barkocot/lwpck-2996 branch April 1, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@illsilin illsilin illsilin approved these changes

@spolifroni-amd spolifroni-amd spolifroni-amd approved these changes

@geyyer geyyer geyyer left review comments

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@qianfengz qianfengz Awaiting requested review from qianfengz qianfengz is a code owner

@aosewski aosewski Awaiting requested review from aosewski aosewski is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@andriy-ca andriy-ca Awaiting requested review from andriy-ca andriy-ca is a code owner

@afagaj afagaj Awaiting requested review from afagaj afagaj is a code owner

@asleepzzz asleepzzz Awaiting requested review from asleepzzz asleepzzz is a code owner

@tenpercent tenpercent Awaiting requested review from tenpercent tenpercent is a code owner

Assignees

@bartekxk bartekxk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bartekxk @geyyer @illsilin @spolifroni-amd