[dileepr1]

Motivation

In Short:

#8268 fixes two independent bugs that together made every host-ASan hip-tests shard fail without running a single test.
First, is_asan() matched BUILD_VARIANT exactly against "asan", so it was false for host-asan and everything gated on it silently did nothing
Second, configure_asan_env.py pinned the runtime filename to libclang_rt.asan.so, which #8077 renamed to libclang_rt.asan-.so, so the ASan runtime hadn't resolved at all since that landed.

Details

GitHub issue: #7202

Found while looking at the first host-asan presubmit run that got as far as the component test matrix (ROCm/rocm-systems#10088, run 35004915528). All four hip-tests shards failed without running a single test, and with zero AddressSanitizer findings:

catch_tests/RTC: error while loading shared libraries: libclang_rt.asan-x86_64.so: cannot open shared object file
CMake Error at CatchAddTests.cmake:82: Error listing tests from executable '.../RTC': Result: 127
ctest ... returned non-zero exit status 8

ctest runs RTC --list-tests to enumerate Catch2 tests; it cannot load the instrumented binary, CMake aborts the listing, and the shard reports failure. Two separate defects combine to produce this.

1. is_asan() excluded host-asan

return BUILD_VARIANT == "asan"

An exact match, so host-asan (and asan-debug, host-asan-debug) evaluated false and everything gated on it silently did nothing:

Caller	What was skipped
test_hiptests.py	LD_PRELOAD of the runtime, HSA_XNACK, extended timeout
test_rocprofiler_sdk.py	clang resource dir on the loader path, preload, ASAN test exclusions
test_hipfile.py	preload
test_rocblas.py, test_hipblas.py, test_hipblaslt.py	HSA_XNACK
tests/test_rocm_sanity.py	the #3312 rocminfo skip

The test_hiptests.py preload is the one that breaks discovery. Notably the machinery was already correct — get_asan_lib_path() there asks clang for libclang_rt.asan-<arch>.so, exactly the name RTC needs — it just never ran.

The rest of the codebase already treats these as a family: fetch_test_configurations.py uses "asan" in build_variant with a comment listing all four variants, configure_multi_arch_ci.py uses suffix in ("asan", "host-asan"), and publish_rocm_to_release_buckets.py has _is_asan_variant(). is_asan() was the odd one out.

2. configure_asan_env.py pinned one runtime filename

ASAN_RUNTIME_LIB = "libclang_rt.asan.so" is the per-target-runtime-dir name. #8077 (cd8ed0c3f) set LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=OFF, moving the runtime to lib/linux/libclang_rt.asan-<arch>.so. Resolution has failed ever since, and every ASAN test job has been logging ##[warning]ASAN runtime not found. The regression is visible across runs:

Run	TheRock base	Result
34549006044	b85dc2119 (pre-#8077)	resolved .../x86_64-unknown-linux-gnu/libclang_rt.asan.so
34613837319	24cc5c7d6	not found
35004915528	24cc5c7d6	not found

Technical Details

is_asan() now matches any ASAN-family variant via "asan" in BUILD_VARIANT, mirroring fetch_test_configurations.py.

_resolve_asan_runtime() tries both filenames in turn, per-target first then the legacy arch-suffixed one, relying on the fact that clang echoes the requested name back unchanged when it cannot locate the file. The warning now names both candidates. TheRock has flipped between these layouts, so pinning either one is fragile.

Test Plan

• python -m pytest build_tools/ tests/ -q --continue-on-collection-errors (against baseline)
• pre-commit run --files build_tools/github_actions/amdgpu_family_matrix.py build_tools/github_actions/configure_asan_env.py build_tools/github_actions/tests/configure_asan_env_test.py

Test Result

2432 passed / 16 failed / 6 collection errors, against a baseline of 2431 passed / 16 failed / 6 collection errors on origin/main. The failures and collection errors are identical on both sides and are pre-existing local dependency gaps (zlib_ng, pkginfo, _rocm_sdk_core_DEFAULT); the delta is the one test added here. Targeted pre-commit passed.

Risk Assessment

Risk 3. Widening is_asan() activates ASAN handling for host-asan across several test scripts that have never had it, which is the intent but does change their behavior. The specific known side effect is that the TheRock#3312 rocminfo skip now applies to host-asan. That skipif is parametrized over three search patterns, so three sanity tests that were passing under host-asan are now skipped, taking the sanity tally from 1 failed, 4 passed, 3 skipped to 1 failed, 1 passed, 6 skipped:

test_rocm_output[rocminfo - GPU Device Type Search]   SKIPPED
test_rocm_output[rocminfo - GFX Name Search]          SKIPPED
test_rocm_output[rocminfo - AMD Vendor Name Search]   SKIPPED

That coverage loss is accepted here in exchange for the variants behaving consistently. Worth a follow-up: #3312 was filed against full ASAN, and these tests demonstrably pass under host-asan, so narrowing that skipif to the full-ASAN variant may be the better long-term answer. The runtime-name change is additive: it only adds a second candidate after the existing one fails.

Related

• Work tracking: [issue] [asan] Support runtime-only host-ASan presubmit builds and tests #7202
• Caused the rename: revert(compiler): LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON #8077
• Depends on nothing; independent of feat(ci): enable host-asan tests for external repo presubmit builds #7780 and fix(ci): make ASAN sanity findings reachable and readable #8100

Device / Architecture Coverage

Validated on gfx942 via the rocm-systems host-asan presubmit. No device code changes.

Testing Summary

Added test_resolves_the_legacy_arch_suffixed_runtime, which stubs a clang that resolves only the arch-suffixed name and echoes the request back otherwise, matching real clang behavior. Existing coverage for the per-target name, missing clang, missing runtime, missing symbolizer and the GITHUB_ENV format is unchanged.

Testing Checklist

• Full unit suite vs baseline - Status: Passed, no regressions
• Targeted pre-commit - Status: Passed
• host-asan presubmit against test(ci): exercise the runtime-only host-ASAN presubmit (validation for TheRock#7311) rocm-systems#10088 - run 35140846158 - Status: Passed. hip-tests went from 0 tests discovered to ~4,900 run across 4 shards (~2,050 passing). Every remaining failure is the pre-existing hsa_amd_memory_pool_free bad-free. The runtime now resolves to .../lib/clang/24/lib/linux/libclang_rt.asan-x86_64.so, confirming the revert(compiler): LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON #8077 layout.
• PR CI - Status: Pending

Flags / Guardrails

None.

Adjacent Tests Considered

rocprofiler_sdk_dashboard_test.py patches is_asan directly rather than driving it through BUILD_VARIANT, so it is unaffected by the widening and needed no change.

Risk Acceptance / Waivers

None.

Technical Changes

• is_asan() matches any ASAN-family BUILD_VARIANT instead of exactly "asan".
• configure_asan_env.py resolves the ASAN runtime under either the per-target or the legacy arch-suffixed filename.
• Add a unit test for the legacy name.

Submission Checklist

• Look over the contributing guidelines at https://github.com/ROCm/TheRock/blob/main/CONTRIBUTING.md.

[therock-pr-bot]

✅ All Policy Checks Passed

Check	Status	Details
📝 PR Description	✅ Pass	—
⛔ Forbidden Files	✅ Pass	—
🧪 Unit Test	✅ Pass	—
🚫 Draft PR	🔜 To Be Enabled	—
🚩 Feature Flag	🔜 To Be Enabled	—
📊 Code Coverage	🔜 To Be Enabled	—

🎉 All policy checks passed!

📖 Need help? See the Policy FAQ for details on every check and how to fix failures.

🙋 Wish to Override Policy?

[therock-pr-bot]

🎉 All checks passed! This PR is ready for review.

[ScottTodd]

Expanding this is also going to skip our test for rocminfo here:

TheRock/tests/test_rocm_sanity.py

Lines 58 to 63 in 8438943

	class TestROCmSanity:
	@pytest.mark.skipif(is_windows(), reason="rocminfo is not supported on Windows")
	# TODO(#3312): Re-enable once rocminfo test is fixed for ASAN builds
	@pytest.mark.skipif(
	is_asan(), reason="rocminfo test fails with ASAN build, see TheRock#3312"
	)

We may want to differentiate between host asan and device asan in test skipping.

[dileepr1]

Agree!
I'll get a new PR for it after merging, and update this comment as well.

[ScottTodd]

We have some other code across the project that is also checking for the asan runtime path, such as

TheRock/build_tools/github_actions/test_executable_scripts/test_hiptests.py

Lines 109 to 120 in 8438943

	def get_asan_lib_path():
	arch = platform.machine()
	CLANG_PATH = str(Path(THEROCK_BIN_DIR).parent / "lib" / "llvm" / "bin" / "clang++")
	cmd = [f"{CLANG_PATH}", f"--print-file-name=libclang_rt.asan-{arch}.so"]
	logging.info(f"++ Exec [{CLANG_PATH}]$ {shlex.join(cmd)}")
	result = subprocess.run(
	cmd,
	check=True,
	text=True,
	capture_output=True,
	)
	return result.stdout.strip()

I also want our tests to match our documentation in more places, e.g. https://github.com/ROCm/TheRock/blob/main/docs/development/sanitizers.md#step-2-locate-the-asan-runtime-directory

I think this is fine for now though.