Add ability to run external binary modules #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 8, 2023 05:13
Specify runnable binary location and params in conf
jkottiku
requested changes
Dec 13, 2023
jkottiku
requested changes
Mar 18, 2024
|
Add new module details in rvs/src/rvsexec.cpp and rvs/src/rvs_interface.cpp as well. |
added 2 commits
March 19, 2024 04:53
jkottiku
approved these changes
Mar 19, 2024
| @@ -22,10 +22,10 @@ | |||
| * SOFTWARE. | |||
| * | |||
| *******************************************************************************/ | |||
| #ifndef HIPTEST_SO_INCLUDE_RVS_MODULE_H_ | |||
| #define HIPTEST_SO_INCLUDE_RVS_MODULE_H_ | |||
| #ifndef EM_SO_INCLUDE?RVS_MODULE_H_ | |||
There was a problem hiding this comment.
Seems typo. Underscore "_" expected instead of "?" right ?
added 2 commits
March 20, 2024 00:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Til now, RVS runs only modules that are compiled as part of RVS code as shared objects , this module enables us to run pre compiled external binaries via conf file .
Can run one module at once via conf now. can modify test-path and test-args .