Fix bug in parse_resize with nonstandard input shapes #4444
+124
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedThemistokleous
approved these changes
Nov 18, 2025
TedThemistokleous
added
bugfix
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #4444 +/- ##
===========================================
- Coverage 92.21% 92.21% -0.00%
===========================================
Files 560 561 +1
Lines 26743 27228 +485
===========================================
+ Hits 24660 25107 +447
- Misses 2083 2121 +38
🚀 New features to boost your workflow:
|
causten
approved these changes
Nov 18, 2025
Copilot finished reviewing on behalf of
causten
November 18, 2025 20:24
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug in the ONNX resize operator parsing where nonstandard input shapes (e.g., transposed or broadcasted tensors) would cause incorrect index calculations during linear mode interpolation. The fix ensures the input shape is converted to standard form before computing neighbor point indices.
- Converts input shape to standard form before passing to
calc_neighbor_pointsfunction - Fixes incorrect index calculations for inputs with non-contiguous strides
- Maintains consistency with similar shape handling in other parts of the codebase
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Test added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Changelog Category