Create op. builders (4.) #4385
Open
Create op. builders (4.) #4385
+649
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… op-builder class
…er multiple numbers of op-builders
…is essentially the same how add_instruction is called a few lines above
…hat the tests run not for only one kind of binary operator
… parameter optional on the op-builder side
…erence would be there
…a default value for the 'options' parameter for an op-builder
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #4385 +/- ##
===========================================
+ Coverage 92.18% 92.24% +0.06%
===========================================
Files 560 563 +3
Lines 26641 27274 +633
===========================================
+ Hits 24558 25158 +600
- Misses 2083 2116 +33
🚀 New features to boost your workflow:
|
…tor as it arrives; in case of the TF parser we have to modify the input vector that will be passed to the op-builder. We won't need the last item.
…e-parameter functions
pfultz2
reviewed
Nov 12, 2025
pfultz2
reviewed
Nov 12, 2025
pfultz2
reviewed
Nov 12, 2025
…-op op-builder and modify tests accrodingly
…ucing default op-builder when it's not amongst the registered ones
kahmed10
approved these changes
Nov 17, 2025
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
pfultz2
reviewed
Nov 26, 2025
pfultz2
reviewed
Nov 26, 2025
pfultz2
reviewed
Nov 26, 2025
pfultz2
reviewed
Nov 26, 2025
…ne; otherwise the wrong constructor would be called
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The whole purpose of the op-builders is to factor out the main functionalities behind the current onnx parsers and put them in a separate set of files (under the folder ./src/op/builder/ ) so they could be reused in different parts of the application. That is this is mainly a refactoring task; the passing of the already existing unit and verify tests should be the proof that the refactoring left the integrity of mgr intact.
related issue: migraphx-benchmark#203
covered parsers in this PR: