Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove rocBLAS bug workaround for solution index #3856

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Remove rocBLAS bug workaround for solution index #3856

merged 1 commit into from
Mar 3, 2025

Conversation

ahsan-ca
Copy link
Contributor

No description provided.

@ahsan-ca ahsan-ca self-assigned this Feb 28, 2025
@ahsan-ca ahsan-ca requested a review from causten as a code owner February 28, 2025 17:09
@ahsan-ca ahsan-ca linked an issue Feb 28, 2025 that may be closed by this pull request
Remove rocBLAS bug workaround for solution index #2877
Closed
@TedThemistokleous TedThemistokleous added roadmap Tasks to finish for a release simple small or simple changes Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR labels Feb 28, 2025
causten
causten approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@causten causten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In CI at some point we will be running without the workaround and with ROCm 6.3. Will this be an issue?

@ahsan-ca
Copy link
Contributor Author

In CI at some point we will be running without the workaround and with ROCm 6.3. Will this be an issue?

I am doing testing at my end, I also put up the PR to kick off CI testing to see if it breaks anything.

@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.41%. Comparing base (c62f940) to head (7b9b56a).
Report is 4 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #3856   +/-   ##
========================================
  Coverage    92.41%   92.41%           
========================================
  Files          520      520           
  Lines        22471    22471           
========================================
  Hits         20766    20766           
  Misses        1705     1705

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@causten causten merged commit 168ea64 into develop Mar 3, 2025
43 of 47 checks passed
@causten causten deleted the remove-rocblas-bug-fix branch March 3, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@causten causten causten approved these changes

@TedThemistokleous TedThemistokleous TedThemistokleous approved these changes

@aarushjain29 aarushjain29 aarushjain29 approved these changes

Assignees

@ahsan-ca ahsan-ca

Labels
Cleanup Cleans up code from stale bits/warnings/previous changes for a previous feature PR roadmap Tasks to finish for a release simple small or simple changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove rocBLAS bug workaround for solution index
4 participants
@ahsan-ca @causten @TedThemistokleous @aarushjain29