-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md for 6.4 #3847
base: release/rocm-rel-6.4
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/rocm-rel-6.4 #3847 +/- ##
=====================================================
Coverage 92.33% 92.33%
=====================================================
Files 519 519
Lines 22261 22261
=====================================================
Hits 20555 20555
Misses 1706 1706 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Ahsan Saghir <[email protected]>
Co-authored-by: Ahsan Saghir <[email protected]>
Co-authored-by: Ahsan Saghir <[email protected]>
Co-authored-by: Ahsan Saghir <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog needs some work, mostly in terms of adding context and specificity. How the changes/additions/removals/optimizations affect the user needs to be specified. Anything that won't affect the user can be removed.
Co-authored-by: Ahsan Saghir <[email protected]>
Co-authored-by: spolifroni-amd <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes. I'm going to approve so you don't have to wait for me.
* Fixed multistream execution with larger models (#3757) | ||
* Peephole LSTM Error (#3768) | ||
* Fixed BertSquad example that could include a broken tokenizers package (#3556) | ||
* Fixed Attention fusion ito not error with a shape mismatch when a trailing pointwise contains a literal (#3758) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a typo or is it something that needs to be in quotes/preformatted text?
|
||
* Support for gfx1200 and gfx1201 | ||
* hipBLASLt support for contiguous transpose GEMM fusion and GEMM pointwise fusions for improved performance | ||
* Support for hardware specific FP8 datatypes (FP8 OCP and FP8 FNUZ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because below everything starts with "added", this either needs to start with "added" or nothing needs to start with "added". It's easier to add "added" to these three lines
* Included the min/max/median of the `perf` run as part of the summary report | ||
* Enable non-packed inputs for `rocMLIR` | ||
* Always output a packed type for q/dq after determining non-packed tensors were inefficient | ||
* Even if using NHWC, MIGraphX will always convert group convolutions to NCHW for best performance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Even if using NHWC, MIGraphX will always convert group convolutions to NCHW for best performance | |
* MIGraphX will always convert group convolutions to NCHW for best performance, including when using NHWC. |
Changes made for 6.4. Review for spelling, punctuation and accuracy