Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG.md for 6.4 #3847

Open
wants to merge 9 commits into
base: release/rocm-rel-6.4
Choose a base branch
from
Open

Conversation

causten
Copy link
Collaborator

@causten causten commented Feb 26, 2025

Changes made for 6.4. Review for spelling, punctuation and accuracy

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.33%. Comparing base (cb6e973) to head (9325bd9).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/rocm-rel-6.4    #3847   +/-   ##
=====================================================
  Coverage                 92.33%   92.33%           
=====================================================
  Files                       519      519           
  Lines                     22261    22261           
=====================================================
  Hits                      20555    20555           
  Misses                     1706     1706           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

causten and others added 4 commits February 26, 2025 09:07
Co-authored-by: Ahsan Saghir <[email protected]>
Co-authored-by: Ahsan Saghir <[email protected]>
Co-authored-by: Ahsan Saghir <[email protected]>
Co-authored-by: Ahsan Saghir <[email protected]>
@causten causten requested a review from ahsan-ca February 26, 2025 14:08
Copy link
Contributor

@ahsan-ca ahsan-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog needs some work, mostly in terms of adding context and specificity. How the changes/additions/removals/optimizations affect the user needs to be specified. Anything that won't affect the user can be removed.

Copy link
Contributor

@spolifroni-amd spolifroni-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes. I'm going to approve so you don't have to wait for me.

* Fixed multistream execution with larger models (#3757)
* Peephole LSTM Error (#3768)
* Fixed BertSquad example that could include a broken tokenizers package (#3556)
* Fixed Attention fusion ito not error with a shape mismatch when a trailing pointwise contains a literal (#3758)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo or is it something that needs to be in quotes/preformatted text?


* Support for gfx1200 and gfx1201
* hipBLASLt support for contiguous transpose GEMM fusion and GEMM pointwise fusions for improved performance
* Support for hardware specific FP8 datatypes (FP8 OCP and FP8 FNUZ)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because below everything starts with "added", this either needs to start with "added" or nothing needs to start with "added". It's easier to add "added" to these three lines

* Included the min/max/median of the `perf` run as part of the summary report
* Enable non-packed inputs for `rocMLIR`
* Always output a packed type for q/dq after determining non-packed tensors were inefficient
* Even if using NHWC, MIGraphX will always convert group convolutions to NCHW for best performance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Even if using NHWC, MIGraphX will always convert group convolutions to NCHW for best performance
* MIGraphX will always convert group convolutions to NCHW for best performance, including when using NHWC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants