Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default workspace size for hipBLASLt when no algo is provided #3837

Merged
merged 1 commit into from
Feb 22, 2025

Conversation

ahsan-ca
Copy link
Contributor

@ahsan-ca ahsan-ca commented Feb 21, 2025

When hipBLASLt does not provide an algo, we use the default workspace size.

@ahsan-ca ahsan-ca added high priority A PR with high priority for review and merging. simple small or simple changes labels Feb 21, 2025
@ahsan-ca ahsan-ca self-assigned this Feb 21, 2025
@ahsan-ca ahsan-ca requested a review from causten as a code owner February 21, 2025 14:58
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.35%. Comparing base (3e17c5a) to head (4887b9a).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3837   +/-   ##
========================================
  Coverage    92.35%   92.35%           
========================================
  Files          519      519           
  Lines        22311    22311           
========================================
  Hits         20606    20606           
  Misses        1705     1705           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahsan-ca ahsan-ca force-pushed the fix-hipblaslt-sol-idx-0 branch from f0881c3 to 2baa612 Compare February 21, 2025 15:16
@ahsan-ca ahsan-ca changed the title Return default workspace size when no algo is provided Use default workspace size for hipBLASLt when no algo is provided Feb 21, 2025
@ahsan-ca ahsan-ca force-pushed the fix-hipblaslt-sol-idx-0 branch from 2baa612 to 4c73b03 Compare February 21, 2025 15:22
@TedThemistokleous
Copy link
Collaborator

Fix tidy but otherwise lgtm

@ahsan-ca ahsan-ca force-pushed the fix-hipblaslt-sol-idx-0 branch 2 times, most recently from c3d0978 to 79519d3 Compare February 21, 2025 17:50
@ahsan-ca ahsan-ca force-pushed the fix-hipblaslt-sol-idx-0 branch from 79519d3 to 4887b9a Compare February 21, 2025 18:21
@ahsan-ca
Copy link
Contributor Author

ahsan-ca commented Feb 21, 2025

Jenkins failure seems unrelated, restarting Jenkins.

@migraphx-bot
Copy link
Collaborator

Test Batch Rate new
4887b9
Rate old
1aff1a
Diff Compare
torchvision-resnet50 64 3,237.23 3,233.96 0.10%
torchvision-resnet50_fp16 64 6,866.95 6,866.95 0.00%
torchvision-densenet121 32 2,436.18 2,437.82 -0.07%
torchvision-densenet121_fp16 32 4,201.40 4,193.76 0.18%
torchvision-inceptionv3 32 1,613.72 1,613.72 0.00%
torchvision-inceptionv3_fp16 32 2,675.59 2,677.82 -0.08%
cadene-inceptionv4 16 750.12 750.47 -0.05%
cadene-resnext64x4 16 809.72 810.13 -0.05%
slim-mobilenet 64 6,661.59 6,659.77 0.03%
slim-nasnetalarge 64 196.86 196.84 0.01%
slim-resnet50v2 64 3,432.94 3,432.94 0.00%
bert-mrpc-onnx 8 1,134.75 1,131.54 0.28%
bert-mrpc-tf 1 507.61 500.00 1.52%
pytorch-examples-wlang-gru 1 506.68 471.50 7.46% 🔆
pytorch-examples-wlang-lstm 1 453.78 444.16 2.17%
torchvision-resnet50_1 1 793.65 800.00 -0.79%
cadene-dpn92_1 1 430.60 430.99 -0.09%
cadene-resnext101_1 1 390.62 390.62 0.00%
onnx-taau-downsample 1 371.64 371.68 -0.01%
dlrm-criteoterabyte 1 31.82 31.80 0.09%
dlrm-criteoterabyte_fp16 1 51.04 51.06 -0.03%
agentmodel 1 8,803.13 8,563.18 2.80%
unet_fp16 2 58.36 58.24 0.20%
resnet50v1_fp16 1 1,075.27 1,075.27 0.00%
resnet50v1_int8 1 826.45 800.00 3.31% 🔆
bert_base_cased_fp16 64 1,159.00 1,159.00 0.00%
bert_large_uncased_fp16 32 360.24 360.12 0.03%
bert_large_fp16 1 216.92 216.45 0.22%
distilgpt2_fp16 16 2,191.78 2,188.78 0.14%
yolov5s 1 529.41 529.26 0.03%
tinyllama 1 49.12 49.12 0.00%
vicuna-fastchat 1 43.61 43.63 -0.04%
whisper-tiny-encoder 1 436.68 436.68 0.00%
whisper-tiny-decoder 1 448.43 446.43 0.45%

Check results before merge 🔆

@migraphx-bot
Copy link
Collaborator


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@causten causten merged commit 9123559 into develop Feb 22, 2025
45 of 47 checks passed
@causten causten deleted the fix-hipblaslt-sol-idx-0 branch February 22, 2025 15:35
sohbodas pushed a commit to sohbodas/AMDMIGraphX that referenced this pull request Feb 27, 2025
sohbodas pushed a commit to sohbodas/AMDMIGraphX that referenced this pull request Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
high priority A PR with high priority for review and merging. simple small or simple changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants