-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set warmup and tuning iterations through env variable for hipBLASLt #3792
base: develop
Are you sure you want to change the base?
Conversation
src/targets/gpu/hip_gemm_impl.cpp
Outdated
const int hot_calls = 1000; | ||
const int cold_calls = 1000; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@causten In case you'd like to change the iterations for the models you are trying this out with:
cold_calls
alters warmup iterations.
hot_calls
alters tuning iterations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your testing will take a while if you hardcode the values. You'll need to rebuild the code each time. If you allow env variables then you would cut down on recompiling the various scenarios
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added the env variables.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3792 +/- ##
========================================
Coverage 92.29% 92.29%
========================================
Files 519 519
Lines 22233 22233
========================================
Hits 20520 20520
Misses 1713 1713 ☔ View full report in Codecov by Sentry. |
9a36d7b
to
50ec9a0
Compare
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
This is a draft PR with changes to test different number of warmup and tuning iterations for hipBLASLt.